darcs send -o message --edit-description doesn't open text editor and ask for a
description. It works as if --edit-description was not specified. darcs
--edit-description works fine.

On 09-01-07 13:33, Marco Túlio Gontijo e Silva wrote:

> darcs send -o message --edit-description doesn't open text editor and ask for a
> description. It works as if --edit-description was not specified. darcs
> --edit-description works fine.

I'm not sure whether or not --output + --edit-description should call an 
editor or not.  If not, then this combination should give an error 
message.  But it seems ok to allow opening an editor in this case.

Assuming that we want to call the editor, attached is a patch that adds 
a (currently failing) test for this scenario.

Groetjes,
  <><
Marnix

Attachments

• test-for-issue381-support

On Tue, Jan 09, 2007 at 10:17:38PM +0100, Marnix Klooster wrote:
> On 09-01-07 13:33, Marco Túlio Gontijo e Silva wrote:
> 
> >darcs send -o message --edit-description doesn't open text editor and ask 
> >for a
> >description. It works as if --edit-description was not specified. darcs
> >--edit-description works fine.
> 
> I'm not sure whether or not --output + --edit-description should call an 
> editor or not.  If not, then this combination should give an error 
> message.  But it seems ok to allow opening an editor in this case.

I suspect we don't open the editor because normally the --output option
doesn't format the output as an email (and this is probably an unintended
side-effect), but I think we ought to do so.  Not format it as an email,
but format it like we format the email (i.e. add a description at top).

> Assuming that we want to call the editor, attached is a patch that adds 
> a (currently failing) test for this scenario.

Thanks for the patch!
-- 
David Roundy
Department of Physics
Oregon State University

If we do this, we should be careful to not to accidentally create bundles that
we can't parse.  For example, avoid any kind of havoc that might ensue if the
user puts 'New patches:' in the description.

Then again, I suppose dropping characters until we hit the last instance of 'New
patches:' might be ok, so long as nobody happens to be named 'New patches:'

For what it's worth, we could borrow a trick from the patch decriptions by
sticking a space before every line.  But if we do something that depends on such
trickery, we'll also need to output a warning, telling the user not to edit the
description by hand (which might be very tempting)

I've implemented this, but without any sort of protection against users entering
in descriptions that will break darcs' parsing of patch bundles.

David