hi

how to reproduce:

vmiklos@vmobile:~/darcs$ mkdir test
vmiklos@vmobile:~/darcs$ cd test
vmiklos@vmobile:~/darcs/test$ dr init
vmiklos@vmobile:~/darcs/test$ mkdir one
vmiklos@vmobile:~/darcs/test$ cd one
vmiklos@vmobile:~/darcs/test/one$ dr
vmiklos@vmobile:~/darcs/test/one$ mkdir two
vmiklos@vmobile:~/darcs/test/one$ cd two
vmiklos@vmobile:~/darcs/test/one/two$ touch file
vmiklos@vmobile:~/darcs/test/one/two$ dr add file
vmiklos@vmobile:~/darcs/test/one/two$ dr rec .
Recording changes in "one/two":

Darcs needs to know what name (conventionally an email address) to use as the
patch author, e.g. 'Fred Bloggs <fred@bloggs.invalid>'.  If you provide one
now it will be stored in the file '_darcs/prefs/author' and used as a default
in the future.  To change your preferred author address, simply delete or edit
this file.

What is your email address? .
Ok, if you don't want to record anything, that's fine!

expected results:
prompt for adding 2 dirs and an empty file

thanks,
VMiklos

Hi,

Thanks for the report and the how-to-reproduce.

> vmiklos@vmobile:~/darcs$ mkdir test
> vmiklos@vmobile:~/darcs$ cd test
> vmiklos@vmobile:~/darcs/test$ dr init
> vmiklos@vmobile:~/darcs/test$ mkdir one
> vmiklos@vmobile:~/darcs/test$ cd one
> vmiklos@vmobile:~/darcs/test/one$ dr

was this meant to be darcs add . ?

> vmiklos@vmobile:~/darcs/test/one$ mkdir two

don't you need darcs add . here as well?

sorry, forgot that line, i've hit ctrl-c there

no, there is the trick, if you make a new dir and an another inside in the new
dir, then create a new file inside the second dir, then darcs add the file
returns zero error message, but "darcs add ." says there is nothing to record,
while there are 2 new dirs and 1 new file to add

ps: it's a bit weird, i was forced to set the priority of this issue ;) i've set
it to "bug"

On Thu, Feb 01, 2007 at 05:39:56PM +0000, VMiklos wrote:
> how to reproduce:
> 
> vmiklos@vmobile:~/darcs$ mkdir test
> vmiklos@vmobile:~/darcs$ cd test
> vmiklos@vmobile:~/darcs/test$ dr init
> vmiklos@vmobile:~/darcs/test$ mkdir one
> vmiklos@vmobile:~/darcs/test$ cd one
> vmiklos@vmobile:~/darcs/test/one$ dr
> vmiklos@vmobile:~/darcs/test/one$ mkdir two
> vmiklos@vmobile:~/darcs/test/one$ cd two
> vmiklos@vmobile:~/darcs/test/one/two$ touch file
> vmiklos@vmobile:~/darcs/test/one/two$ dr add file
> vmiklos@vmobile:~/darcs/test/one/two$ dr rec .
> Recording changes in "one/two":
> 
> Darcs needs to know what name (conventionally an email address) to use as the
> patch author, e.g. 'Fred Bloggs <fred@bloggs.invalid>'.  If you provide one
> now it will be stored in the file '_darcs/prefs/author' and used as a default
> in the future.  To change your preferred author address, simply delete or edit
> this file.
> 
> What is your email address? .
> Ok, if you don't want to record anything, that's fine!
> 
> expected results:
> prompt for adding 2 dirs and an empty file

It looks like the problem is that you're asking darcs to only record
changes in the directory "one/two," and darcs is refusing because the
addition of the directory "one" is not in directory "one/two".  Does this
fit with what you see?

It looks like the fix is in TouchesFiles.lhs, the "affects" function down
at the bottom.  We say that a patch to "foo/bar" affects "foo" but we don't
say that a patch to "foo" affects "foo/bar" (which it does).  This
shouldn't be hard to fix, but I don't have time to fix it, particularly
since I'd like to see a test added in to go with the fix.
-- 
David Roundy
Department of Physics
Oregon State University

On Fri, Feb 02, 2007 at 08:15:02PM +0000, David Roundy <bugs@darcs.net> wrote:
> It looks like the problem is that you're asking darcs to only record
> changes in the directory "one/two," and darcs is refusing because the
> addition of the directory "one" is not in directory "one/two".  Does this
> fit with what you see?

exactly.

> It looks like the fix is in TouchesFiles.lhs, the "affects" function down
> at the bottom.  We say that a patch to "foo/bar" affects "foo" but we don't
> say that a patch to "foo" affects "foo/bar" (which it does).  This
> shouldn't be hard to fix, but I don't have time to fix it, particularly
> since I'd like to see a test added in to go with the fix.

if that helps, i may try to create such a test, though i don't know
haskell so probably i can't fix the issue

udv / greetings,
VMiklos

This appears to have been fixed in darcs 1.0.9 with David's patch

Sat May  5 16:33:30 CEST 2007  David Roundy <droundy@darcs.net>
  * fix bug where we add a file but not its boring parent directory.

I did the test and got the two prompts.  Thanks for spotting that.