darcs

Issue 446 obliterate --tags => bug in get_extra commuting patch (1.0.9rc2)

Title obliterate --tags => bug in get_extra commuting patch (1.0.9rc2)
Priority bug Status resolved
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, gour, kowey, markstos, thorkilnaur, tommy, zooko
Assigned To zooko
Topics

Created on 2007-04-26.19:54:44 by zooko, last changed 2009-08-27.14:06:39 by admin.

Files
File name Uploaded Type Edit Remove
dxv.bz2 zooko, 2007-04-26.19:54:37 application/octet-stream
Messages
msg1664 (view) Author: zooko Date: 2007-04-26.19:54:37
- - - - begin included shell transcript
HACM yumyum:~/playground/zfec/zfec-broken$ darcs oblit --tag=

Sun Apr 15 16:28:42 MDT 2007  "Zooko O'Whielacronx <zooko@zooko.com>"
  tagged 1.0.0a1-2-STABLE
Shall I obliterate this patch? (1/?)  [ynWvpxqadjkc], or ? for help: y
darcs: bug in get_extra commuting patch:
Wed Apr 18 17:01:03 MDT 2007  zooko@zooko.com
  * zfec: update docs, metadata, version number to 1.0.0a2-0-STABLE
HACM yumyum:~/playground/zfec/zfec-broken$ darcs check
Applying patch 107 of 107... done.
The repository is consistent!
HACM yumyum:~/playground/zfec/zfec-broken$ darcs repair
Applying patch 107 of 107... done.
The repository is already consistent, no changes made.
HACM yumyum:~/playground/zfec/zfec-broken$ darcs --exact-version > /tmp/dxv
HACM yumyum:~/playground/zfec/zfec-broken$ bzip2 -9 /tmp/dxv
HACM yumyum:~/playground/zfec/zfec-broken$ darcs --version
1.0.9rc2 (stable branch)
 - - - - end included shell transcript

The entire repository exactly as shown here is available at:

https://yumyum.zooko.com:32325/pub/zfec-broken.tar.bz2

and under less common but better compression schemes:

https://yumyum.zooko.com:32325/pub/zfec-broken.tar.rz

https://yumyum.zooko.com:32325/pub/zfec-broken.tar.lrz
Attachments
msg1689 (view) Author: dagit Date: 2007-05-11.07:15:21
I spent some time adding Debug.Trace statements inside Commute.lhs and narrowed
this down to a failed commute with the following hunks:

hunk ./zfec/zfec/__init__.py 13
-__version__ = Version("1.0.0a2-0-STABLE")
+__version__ = Version("1.0.0a2-1-STABLE")


hunk ./zfec/zfec/__init__.py 13
-__version__ = Version("1.0.0a1-2-STABLE")
+__version__ = Version("1.0.0a2-0-STABLE")

It makes sense that these hunks fail to commute.  One depends on the other. 
What I haven't figured out is why darcs needs to commute them here.
msg3273 (view) Author: markstos Date: 2008-02-09.18:41:06
Zooko,

I'm not able to connect to the provided URL today. Could you use darcs2 to run a
"darcs convert" on the repo and see if the issue still occurs? 

  Mark
msg3291 (view) Author: zooko Date: 2008-02-09.22:54:02
Okay, I have a copy of my "zfec-broken" repo, so I'm trying to reproduce this.

The first thing that I observe is this:

------- begin included cut and paste
MAIN wonwin-mcbrootles-computer:~/playground/darcsbugtest/zfec-broken$ darcs
oblit --tag=

darcs failed:  Text.Regex.Posix.String died: (ReturnCode 14,"empty (sub)expression")
------- end included cut and paste

When did this change??  This is darcs-1.0.9 release.  Did I compile it
differently or something?
msg3293 (view) Author: markstos Date: 2008-02-10.01:21:26
Zooko,

I find the error message you are getting now to be reasonable. Using "--tag="
without a regexp is not documented to work, that is essentially what the error
message is complaining about, although an overly geeky way. 

Could you continue to test with "--tag='1.0.0a1-2-STABLE'"  ?

   Mark
msg3294 (view) Author: zooko Date: 2008-02-10.01:32:45
Okay, I reproduced it like this:

I used "--tag=1" instead of "--tag=" in order to avoid the aforementioned change
in regex parsing.

With darcs-1.0.9 I got the same error when I tried to obliterate the first
matching tag -- the one named "zfec 1.0.0a2-0-STABLE", so I reproduced this with
darcs-1.0.9.  Then with darcs-1.0.10pre -- same behavior.  Then I tried it with
darcs-2pre on the old-format repo -- same behavior.  Then I tried it with
darcs-2pre on a hashed-format repo -- the bug is fixed!  Then I tried it with
darcs-2pre on a darcs-2-format repo -- the bug is fixed!
msg3875 (view) Author: gour Date: 2008-03-12.18:38:46
Hi!

Today I built darcs by pulling latest patches from 'unstable' on my x86_64 box.

Attempt to push some patches from laptop to desktop results in:

gour@nitai ~/d/emacs> darcs push -v gour@gaura-nitai.no-ip.org:darcs/emacs
darcs: bug in get_extra commuting patch:
Mon Feb 11 08:51:15 CET 2008  dev@atmarama.org
  * new version of GnusSync

gour@nitai ~> darcs --exact-version
darcs compiled on Mar 12 2008, at 14:36:06
unknown

gour@nitai ~/org> ghc -v
Glasgow Haskell Compiler, Version 6.8.2, for Haskell 98, stage 2 booted by GHC
version 6.8.1


Sincerely,
Gour
History
Date User Action Args
2007-04-26 19:54:44zookocreate
2007-05-11 07:15:31dagitsetstatus: unread -> unknown
nosy: + dagit
messages: + msg1689
2007-07-23 20:37:35koweysetnosy: droundy, tommy, beschmi, kowey, zooko, dagit
title: darcs: bug in get_extra commuting patch: -> obliterate --tag => bug in get_extra commuting patch (1.0.9rc2)
2007-07-23 20:43:27koweysettitle: obliterate --tag => bug in get_extra commuting patch (1.0.9rc2) -> obliterate --tags => bug in get_extra commuting patch (1.0.9rc2)
2008-02-09 18:41:07markstossetstatus: unknown -> testing
nosy: + markstos
messages: + msg3273
assignedto: zooko
2008-02-09 22:54:03zookosetnosy: droundy, tommy, beschmi, kowey, markstos, zooko, dagit
messages: + msg3291
2008-02-10 01:21:27markstossetnosy: droundy, tommy, beschmi, kowey, markstos, zooko, dagit
messages: + msg3293
2008-02-10 01:32:46zookosetnosy: droundy, tommy, beschmi, kowey, markstos, zooko, dagit
messages: + msg3294
2008-02-10 01:32:58zookosetstatus: testing -> resolved-in-unstable
nosy: droundy, tommy, beschmi, kowey, markstos, zooko, dagit
2008-03-12 18:38:47goursetnosy: + gour
messages: + msg3875
2008-09-04 21:30:54adminsetstatus: resolved-in-unstable -> resolved
nosy: droundy, tommy, beschmi, kowey, markstos, zooko, dagit, gour
2009-08-06 17:36:21adminsetnosy: + jast, Serware, dmitry.kurochkin, darcs-devel, mornfall, simon, thorkilnaur, - droundy, gour
2009-08-06 20:33:24adminsetnosy: - beschmi
2009-08-10 22:03:35adminsetnosy: + gour, - darcs-devel, jast, Serware, mornfall
2009-08-11 00:00:24adminsetnosy: - dagit
2009-08-25 17:50:20adminsetnosy: + darcs-devel, - simon
2009-08-27 14:06:39adminsetnosy: tommy, kowey, markstos, darcs-devel, zooko, thorkilnaur, gour, dmitry.kurochkin