darcs

Issue 455 'darcs unrecord' doesn't remove the patch file

Title 'darcs unrecord' doesn't remove the patch file
Priority bug Status resolved
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, giksos, kowey, thorkilnaur, tommy
Assigned To
Topics FauxBug

Created on 2007-05-10.02:54:41 by giksos, last changed 2009-08-27.13:49:53 by admin.

Messages
msg1681 (view) Author: giksos Date: 2007-05-10.02:54:40
when I do 'darcs unrecord', the corresponding *.gz file in _darcs/patches
doesn't get removed. This seems to contradict the documentation, saying "The
unrecorded patch however is actually removed from your repository".
msg1683 (view) Author: tommy Date: 2007-05-10.06:57:22
On Thu, May 10, 2007 at 02:54:42AM +0000, Misha Aizatulin wrote:
> when I do 'darcs unrecord', the corresponding *.gz file in _darcs/patches
> doesn't get removed. This seems to contradict the documentation, saying "The
> unrecorded patch however is actually removed from your repository".

I think there is already a feature request somewhere in the bug
tracker for a --clean flag to Optimize to remove unused patch
files.

But they currently serve two purposes (that I can think of). If
a patch is unpulled and then pulled back again, the .gz file is
(some times) reused, which is good if the file is actually a
hard link. It's a common case with darcs to Get a temp repo
(this creates hard links) and do repeated Unpull / Pull there to
go to various previous versions of the repos contents. And the
left .gz files can also be used to examine and possibly patch
together a broken repo.

Note that Unrecord / Unpull / Obliterate do removes the
reference to the .gz file from the inventory, and the
reference's _position_ in the inventory is a vital part of the
patch's information, so the patch _is_ indeed lost.

One way to get a "clean" repo is to Get it and replace the old
one, as Get doesn't copy / link unreferenced .gz files.
History
Date User Action Args
2007-05-10 02:54:41giksoscreate
2007-05-10 06:57:40tommysetstatus: unread -> unknown
nosy: droundy, tommy, beschmi, kowey, giksos
messages: + msg1683
2007-07-16 00:55:40koweysetstatus: unknown -> resolved
nosy: droundy, tommy, beschmi, kowey, giksos
topic: + FauxBug
2009-08-06 17:43:31adminsetnosy: + markstos, jast, Serware, dmitry.kurochkin, darcs-devel, zooko, dagit, mornfall, simon, thorkilnaur, - droundy, giksos
2009-08-06 20:40:26adminsetnosy: - beschmi
2009-08-10 22:04:05adminsetnosy: + giksos, - markstos, darcs-devel, zooko, jast, dagit, Serware, mornfall
2009-08-25 17:56:36adminsetnosy: + darcs-devel, - simon
2009-08-27 13:49:53adminsetnosy: tommy, kowey, darcs-devel, giksos, thorkilnaur, dmitry.kurochkin