Created on 2007-06-05.11:43:00 by ed101, last changed 2009-10-23.23:29:31 by admin.
msg1712 (view) |
Author: ed101 |
Date: 2007-06-05.11:42:52 |
|
seems like the regexps in the binaries file are matched against only the
filename. this is inconsistent with the boring file behaviour and also less useful.
if it's doable, please change it to match against the entire path.
|
msg3012 (view) |
Author: markstos |
Date: 2008-02-01.03:09:34 |
|
I confirmed that the behavior works as reported with Darcs2:
- 'boring' matches on the full path
- 'binaries' matches on the file name
The docs are clear that boring matches on the file path, but docs about
'binaries' are left open on this point.
I agree that matching the whole path is more flexible, and there are reasonable
"use cases" for it. Consider "/usr/bin", which contains a lot of binaries
without extensions.
I think there is some good news in that the default "binary" file format would
be forward compatible because it only matches file extensions, which would also
work for *file-path* endings.
The Darcs2 flag day seems like a good time to make this change, if developers
want to move forward with it.
|
msg3028 (view) |
Author: droundy |
Date: 2008-02-01.15:28:46 |
|
I'm pushing now an untested fix for this. Please close this (and maybe add a
test?) if this works. Thanks for the report!
|
msg3051 (view) |
Author: markstos |
Date: 2008-02-02.02:54:23 |
|
I can confirm that this seems to work now based on manual testing of a new build.
An automated test has also been sent now.
Thanks for the update, David!
|
|
Date |
User |
Action |
Args |
2007-06-05 11:43:00 | ed101 | create | |
2007-06-05 11:43:40 | ed101 | set | topic:
+ ProbablyEasy nosy:
droundy, tommy, beschmi, kowey, ed101 |
2008-02-01 03:09:38 | markstos | set | status: unread -> unknown nosy:
+ markstos, jaredj topic:
+ Confirmed, Darcs2 messages:
+ msg3012 |
2008-02-01 15:28:51 | droundy | set | nosy:
droundy, tommy, beschmi, kowey, markstos, ed101, jaredj messages:
+ msg3028 |
2008-02-01 19:09:23 | markstos | set | status: unknown -> testing nosy:
droundy, tommy, beschmi, kowey, markstos, ed101, jaredj assignedto: markstos |
2008-02-02 02:54:26 | markstos | set | status: testing -> resolved-in-unstable nosy:
droundy, tommy, beschmi, kowey, markstos, ed101, jaredj messages:
+ msg3051 |
2008-08-05 23:29:47 | kowey | set | status: resolved-in-unstable -> resolved nosy:
+ Serware, dagit |
2009-08-06 17:47:11 | admin | set | nosy:
+ jast, dmitry.kurochkin, darcs-devel, zooko, mornfall, simon, thorkilnaur, - droundy, ed101, jaredj |
2009-08-06 20:43:00 | admin | set | nosy:
- beschmi |
2009-08-10 22:04:45 | admin | set | nosy:
+ ed101, jaredj, - darcs-devel, zooko, jast, mornfall |
2009-08-11 00:00:57 | admin | set | nosy:
- dagit |
2009-08-25 17:58:57 | admin | set | nosy:
+ darcs-devel, - simon |
2009-08-27 14:02:15 | admin | set | nosy:
tommy, kowey, markstos, darcs-devel, ed101, thorkilnaur, jaredj, dmitry.kurochkin, Serware |
2009-10-23 22:43:40 | admin | set | nosy:
+ serware, - Serware |
2009-10-23 23:29:31 | admin | set | nosy:
+ Serware, - serware |
|