darcs

Issue 489 wish: use recorded version of test pref, not the working one

Title wish: use recorded version of test pref, not the working one
Priority wishlist Status wont-fix
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, kowey, lemming, thorkilnaur, tommy
Assigned To
Topics ProbablyEasy

Created on 2007-06-24.10:05:17 by lemming, last changed 2009-08-27.13:55:58 by admin.

Messages
msg1750 (view) Author: lemming Date: 2007-06-24.10:05:16
I haven't updated darcs for long now, due to the difficult installation,
so I have still darcs-1.0.3.

The behaviour of 'darcs setpref test' in this version is not correct I
believe: When I change the 'test' command, but do not record that change,
the modified repository is tested with the new 'test' command
nevertheless. I think that the repository must be tested with the test
recorded in the repository.
msg1808 (view) Author: kowey Date: 2007-07-12.06:53:41
Hi,

Thanks for your comment.  For the record darcs 1.0.8 still behaves this way and
likely 1.0.9.  But why is this incorrect?  It seems more consistent that when I
make a change, it affects the current repository, not just the recorded one.  Cf
darcs replace, for instance.

Besides, you can always darcs revert to get the old test back.

In any case, it would really be a good idea to upgrade your darcs if possible. 
 Many bugs fixed in between 1.0.3 and 1.0.9.

Tentatively marking as resolved.  Feel free to respond (and thereby re-open)
msg1813 (view) Author: lemming Date: 2007-07-12.10:09:24
On Thu, 12 Jul 2007, Eric Kow wrote:

> Eric Kow <eric.kow@gmail.com> added the comment:
>
> Hi,
>
> Thanks for your comment.  For the record darcs 1.0.8 still behaves this way and
> likely 1.0.9.  But why is this incorrect?  It seems more consistent that when I
> make a change, it affects the current repository, not just the recorded one.  Cf
> darcs replace, for instance.

Consider following scenario: I haven't used tests so far. I setup a darcs
test. The test fails. I resolve this bug and record it.  But the test case
still fails. I can record it with -no-test, but I want to show other
participants of the project, that at this point there is no test, that is
satisfied. Thus test settings and tested program parts belong together.

> Besides, you can always darcs revert to get the old test back.

It's not the problem of getting the old test back, it's only the question
how tests and tested parts are bundled.
msg1814 (view) Author: kowey Date: 2007-07-12.11:18:38
Thanks for clarifying that.  Your explanation makes sense to me.

The thing that supports your idea is that the tests are always run on the
recorded version anyway, never the working directory, so in a way, you would
expect only the recorded tests to run as well.
msg1816 (view) Author: lemming Date: 2007-07-12.12:30:00
On Thu, 12 Jul 2007, Eric Kow wrote:

> The thing that supports your idea is that the tests are always run on the
> recorded version anyway, never the working directory,

exactly

> so in a way, you would expect only the recorded tests to run as well.

That's it.

> ----------
> priority: not-our-bug -> bug
> topic: +ProbablyEasy

I don't know if it breaks some setups. One should certainly alert people
about this change.
msg3647 (view) Author: droundy Date: 2008-02-22.21:44:26
This is the desired behavior.  This is needed if users ever need to edit the
test command according to their local setup--which is why the prefs file is
located in _darcs/prefs, so that users can edit it.  The point of prefs, in
short, is repository-specific preferences.
History
Date User Action Args
2007-06-24 10:05:17lemmingcreate
2007-07-12 06:53:43koweysetstatus: unread -> resolved
messages: + msg1808
2007-07-12 10:09:25lemmingsetstatus: resolved -> unknown
messages: + msg1813
2007-07-12 11:18:41koweysetpriority: not-our-bug -> bug
topic: + ProbablyEasy
messages: + msg1814
2007-07-12 12:30:01lemmingsetmessages: + msg1816
2007-08-09 06:08:05koweysettitle: setpref affects patch, also if not recorded -> use recorded version of test pref, not the working one
2007-08-10 10:10:26koweysetpriority: bug -> feature
2008-02-10 02:39:20markstossetpriority: feature -> wishlist
status: unknown -> deferred
nosy: droundy, tommy, beschmi, kowey, lemming
title: use recorded version of test pref, not the working one -> wish: use recorded version of test pref, not the working one
2008-02-22 21:44:27droundysetstatus: deferred -> wont-fix
nosy: droundy, tommy, beschmi, kowey, lemming
messages: + msg3647
2009-08-06 17:38:28adminsetnosy: + markstos, jast, Serware, dmitry.kurochkin, darcs-devel, zooko, dagit, mornfall, simon, thorkilnaur, - droundy, lemming
2009-08-06 20:35:16adminsetnosy: - beschmi
2009-08-10 22:05:43adminsetnosy: + lemming, - markstos, darcs-devel, zooko, jast, dagit, Serware, mornfall
2009-08-25 17:52:05adminsetnosy: + darcs-devel, - simon
2009-08-27 13:55:58adminsetnosy: tommy, kowey, darcs-devel, lemming, thorkilnaur, dmitry.kurochkin