darcs

Issue 503 sanity-check on pulled patches

Title sanity-check on pulled patches
Priority feature Status resolved
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, kowey, lennart.augustsson, thorkilnaur, tommy
Assigned To
Topics FauxBug

Created on 2007-07-23.13:01:55 by lennart.augustsson, last changed 2009-08-27.14:07:14 by admin.

Messages
msg1914 (view) Author: lennart.augustsson Date: 2007-07-23.13:01:54
$ darcs get --partial http://darcs.haskell.org/ghc
This is the GHC darcs repository (HEAD branch)

For more information, visit the GHC developer wiki at
  http://hackage.haskell.org/trac/ghc
**********************
Copying patch 210 of 210... done.
Applying patch 42 of 209... darcs.exe: bug in darcs!
Impossible case at PatchRead.lhs:58 compiled 23:01:08 Jun  4 2007
Please report this to bugs@darcs.net,
If possible include the output of 'darcs --exact-version'.

$ darcs --exact-version
darcs compiled on Jun  4 2007, at 23:02:57
# configured Mon Jun  4 22:59:17 USMST 2007
./configure --disable-mmap

Context:

[TAG 1.0.9
Tommy Pettersson <ptp@lysator.liu.se>**20070603213706] 

This material has been prepared by individual sales and/or trading personnel and does not constitute investment research.  Please follow the attached hyperlink to an important disclaimer: http://www.credit-suisse.com/emea/legal

==============================================================================
Please access the attached hyperlink for an important electronic communications disclaimer: 

http://www.credit-suisse.com/legal/en/disclaimer_email_ib.html
==============================================================================
msg1915 (view) Author: lennart.augustsson Date: 2007-07-23.13:05:24
This issue has been resolved, it was the network generating a bad patch.
Perhaps a sanity check on the patches would be a good idea?

	-- Lennart
msg1918 (view) Author: kowey Date: 2007-07-23.13:41:01
Thanks for that.  There is a new hashed inventory format in the current stable
branch, and it seems like that would help us implement the right sanity checks.
msg3147 (view) Author: kowey Date: 2008-02-06.14:46:29
David, would it make sense to add --verify-hashes as an option to darcs pull?
msg3152 (view) Author: droundy Date: 2008-02-06.16:18:43
Actually, I think it makes more sense to remove the --verify-hashes option
altogether.  For the moment, darcs always checks hashes in any case, regardless
of that flag, and I think I'd prefer to continue this behavior.  We're too
easily bitten by network corruption for me to be really comfortable without this
safety net.  And it doesn't seem that verifying the hashes is really a bottleneck.
History
Date User Action Args
2007-07-23 13:01:55lennart.augustssoncreate
2007-07-23 13:05:24lennart.augustssonsetstatus: unread -> unknown
messages: + msg1915
2007-07-23 13:41:10koweysettopic: + FauxBug
messages: + msg1918
title: Problem with get -> sanity-check on pulled patches
2008-02-06 14:46:31koweysetnosy: droundy, tommy, beschmi, kowey, lennart.augustsson
messages: + msg3147
2008-02-06 16:18:45droundysetstatus: unknown -> resolved-in-unstable
nosy: droundy, tommy, beschmi, kowey, lennart.augustsson
messages: + msg3152
2008-09-04 21:31:18adminsetstatus: resolved-in-unstable -> resolved
nosy: + dagit
2009-08-06 17:43:35adminsetnosy: + markstos, jast, Serware, dmitry.kurochkin, darcs-devel, zooko, mornfall, simon, thorkilnaur, - droundy, lennart.augustsson
2009-08-06 20:40:30adminsetnosy: - beschmi
2009-08-10 22:06:35adminsetnosy: + lennart.augustsson, - markstos, darcs-devel, zooko, jast, Serware, mornfall
2009-08-11 00:01:50adminsetnosy: - dagit
2009-08-25 17:56:40adminsetnosy: + darcs-devel, - simon
2009-08-27 14:07:14adminsetnosy: tommy, kowey, darcs-devel, lennart.augustsson, thorkilnaur, dmitry.kurochkin