Dear People of Darcs:

Thank you, as always, for your work on this valuable tool!

Please observe the following transcript:

------- begin included transcript
HACO wonwin-mcbrootles-computer:~/playground/allmydata/tahoe/trunk- 
hack$ darcs replace --token- 
chars="[ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz_-]" -- 
root-uri --dir-uri docs/configuration.txt

darcs failed:  unrecognized option `--root-uri'

unrecognized option `--dir-uri'

HACO wonwin-mcbrootles-computer:~/playground/allmydata/tahoe/trunk- 
hack$ darcs replace --token- 
chars="[ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz_-]" \\-\ 
\-root\\-uri \\-\\-dir\\-uri docs/configuration.txt

darcs failed:  Bad token spec:   
[ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz_-]
HACO wonwin-mcbrootles-computer:~/playground/allmydata/tahoe/trunk- 
hack$ darcs replace --token- 
chars="[ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz_-]" XXX  
YYY docs/configuration.txt
HACO wonwin-mcbrootles-computer:~/playground/allmydata/tahoe/trunk-hack$
------- end included transcript

Regards,

Zooko

On Jan 1, 2008, at 4:58 PM, Zooko wrote:

> HACO wonwin-mcbrootles-computer:~/playground/allmydata/tahoe/trunk- 
> hack$ darcs replace --token- 
> chars="[ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz_-]" \\- 
> \\-root\\-uri \\-\\-dir\\-uri docs/configuration.txt
>
> darcs failed:  Bad token spec:
> [ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz_-]
> HACO wonwin-mcbrootles-computer:~/playground/allmydata/tahoe/trunk- 
> hack$ darcs replace --token- 
> chars="[ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz_-]"  
> XXX YYY docs/configuration.txt
> HACO wonwin-mcbrootles-computer:~/playground/allmydata/tahoe/trunk- 
> hack$

To be more explicit, I find it confusing that a bad token spec is not  
bad when different OLD and NEW arguments are passed, and I am  
doubtful that the problem with the first command-line quoted above is  
actually that there is something wrong with its token spec.

I also tried the following variant:

-------
darcs replace --token- 
chars="[ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz_\-\.]" \ 
\-\\-root\\-uri \\-\\-dir\\-uri docs/configuration.txt

darcs failed:  Bad token spec:   
[ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz_\-\.]
-------

and then this:

-------
HACO wonwin-mcbrootles-computer:~/playground/allmydata/tahoe/trunk- 
hack$ darcs replace --token-chars="[A-Za-z_0-9\-\.\\]" \\-\\-root\\- 
uri \\-\\-dir\\-uri docs/configuration.txt
HACO wonwin-mcbrootles-computer:~/playground/allmydata/tahoe/trunk-hack$
HACO wonwin-mcbrootles-computer:~/playground/allmydata/tahoe/trunk- 
hack$ darcs whatsnew docs/configuration.txt
What's new in "docs/configuration.txt":

{
replace ./docs/configuration.txt [A-Za-z_0-9\-\.\] \-\-root\-uri \-\- 
dir\-uri
}
-------

which shows, I think, that the problem that yields "Bad token spec"  
is that darcs is receiving a backslash in its OLD and NEW arguments  
and, um, getting confused somehow.

Regards,

Zooko

Resurrecting

Zooko: we now have some new token-char error messages.  Do they help in any way?

The following works for me:

rm -rf R
darcs init --repo R
cd R
cat > f << END
--root-uri
END
darcs add f
darcs record f -am 'initial'
darcs replace --token-chars="[A-Za-z_-]" -- '--root-uri' '--dir-uri' f
grep dir f
cd ..

It results in the following pending patch:
replace ./f [ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz_-] --root-uri
--dir-uri

It sounds like it's little more than some shell/getopt confusion (note the use
of -- AND the use of quotes) than anything else.  So I'm marking this as
'invalid' (since it's not actually a bug, feature request or third-party bug)
and wont-fix accordingly.  Please feel free to re-open if you can turn it into
one of the above, and thanks for the bug report! :-)

Also, in my example above, I meant the following pending: replace ./f [A-Za-z_-]
--root-uri --dir-uri