darcs

Issue 613 get over ssh can leave orphaned directory like "myprojecdarcs-ssh"

Title get over ssh can leave orphaned directory like "myprojecdarcs-ssh"
Priority bug Status resolved
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, eivuokko, jaredj, kowey, markstos, rgm, thorkilnaur, tommy, wglozer, zooko
Assigned To droundy
Topics Darcs2, SSH, Windows

Created on 2008-01-24.23:53:55 by zooko, last changed 2009-10-24.00:08:04 by admin.

Messages
msg2722 (view) Author: zooko Date: 2008-01-24.23:53:53
There is an old bug with darcs that it sometimes leaves an empty  
directory named something like "darcs-ssh".

darcs 2 has modified this into a new and more troublesome form --  
"darcs get" sometimes leaves an empty directory named "myprojecdarcs- 
ssh" or "myprojectdarcs-ssh", where "myproject" was the name of the  
repository that it was asked to create.

Regards,

Zooko
msg2727 (view) Author: markstos Date: 2008-01-25.01:36:04
Zooko,

Thanks for the report. It would be great in the future if your bug reports could
have subjects that were more specific, which makes them more helpful. 

Can you send a long a test sequence which reproduces the issue, preferably in
test-script form?
msg2741 (view) Author: kowey Date: 2008-01-25.14:24:11
> The orphaned directories like "myprojecdarcs-ssh" are sometimes
> created when I do a darcs get over ssh on Windows.  I just tried a
> minimal example -- darcs getting an empty repository over ssh -- and
> it didn't reproduce this bug.
>
> It occurs to me that this is probably an interaction between darcs
> and the putty ssh or ftp client.

Sounds related to the controlmaster code, which creates a darcs-ssh
directory in some temporary location to put the cm file.  Directory is
likely created whether or not we actually use it.
msg2745 (view) Author: droundy Date: 2008-01-25.15:13:18
I've found (and fixed) the bug which causes this directory to get a name other
than darcs-ssh.  I also believe I have fixed the bug that led to unneeded
creation of darcs-ssh directories in the first place.  Thanks for the bug report!

David
msg2786 (view) Author: markstos Date: 2008-01-26.02:04:05
David, 

Looking at this patch that you made:

-  let tmpDarcsSsh = tmp ++ "darcs-ssh"
+  let tmpDarcsSsh = tmp ++ "/darcs-ssh"


Is the embedded "/" going to cause a problem on Windows?
msg2918 (view) Author: droundy Date: 2008-01-30.19:46:34
No, windows handles '/' as equivalent to '\\'.
History
Date User Action Args
2008-01-24 23:53:55zookocreate
2008-01-25 01:36:06markstossetstatus: unread -> unknown
priority: bug
title: weirdly named directories left lying around -> get over ssh can leave orphaned directory like "myproject-ssh"
nosy: + markstos
messages: + msg2727
topic: + SSH, Darcs2
2008-01-25 13:13:38zookosetnosy: droundy, tommy, beschmi, kowey, markstos, zooko
title: get over ssh can leave orphaned directory like "myproject-ssh" -> get over ssh can leave orphaned directory like "myprojecdarcs-ssh"
2008-01-25 13:13:55zookosettopic: + Windows
nosy: + wglozer, eivuokko, rgm, jaredj
2008-01-25 14:24:13koweysetnosy: droundy, tommy, beschmi, kowey, markstos, wglozer, zooko, eivuokko, rgm, jaredj
messages: + msg2741
title: get over ssh can leave orphaned directory like "myprojecdarcs-ssh" -> get over ssh can leave orphaned directory like "myproject-ssh"
2008-01-25 14:29:38koweysetnosy: droundy, tommy, beschmi, kowey, markstos, wglozer, zooko, eivuokko, rgm, jaredj
title: get over ssh can leave orphaned directory like "myproject-ssh" -> get over ssh can leave orphaned directory like "myprojecdarcs-ssh"
2008-01-25 15:13:22droundysetstatus: unknown -> resolved-in-unstable
nosy: droundy, tommy, beschmi, kowey, markstos, wglozer, zooko, eivuokko, rgm, jaredj
messages: + msg2745
2008-01-26 02:04:09markstossetnosy: droundy, tommy, beschmi, kowey, markstos, wglozer, zooko, eivuokko, rgm, jaredj
messages: + msg2786
assignedto: droundy
2008-01-30 19:46:39droundysetnosy: droundy, tommy, beschmi, kowey, markstos, wglozer, zooko, eivuokko, rgm, jaredj
messages: + msg2918
2008-09-04 21:32:09adminsetstatus: resolved-in-unstable -> resolved
nosy: + dagit
2009-08-06 17:52:20adminsetnosy: + jast, Serware, dmitry.kurochkin, darcs-devel, mornfall, simon, thorkilnaur, - droundy, wglozer, eivuokko, rgm, jaredj
2009-08-06 20:55:16adminsetnosy: - beschmi
2009-08-10 22:11:52adminsetnosy: + wglozer, eivuokko, rgm, jaredj, - darcs-devel, jast, Serware, mornfall
2009-08-11 00:05:11adminsetnosy: - dagit
2009-08-25 18:03:49adminsetnosy: + darcs-devel, - simon
2009-08-27 14:08:25adminsetnosy: tommy, kowey, markstos, wglozer, darcs-devel, zooko, eivuokko, rgm, thorkilnaur, jaredj, dmitry.kurochkin
2009-10-23 22:42:11adminsetnosy: + robmoss, - rgm
2009-10-24 00:08:04adminsetnosy: + rgm, - robmoss