darcs

Issue 646 "put" creates a copy with unrecorded changes

Title "put" creates a copy with unrecorded changes
Priority bug Status resolved
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, kowey, markstos, salty-horse, thorkilnaur, tommy
Assigned To markstos
Topics

Created on 2008-02-05.20:57:27 by salty-horse, last changed 2009-08-27.14:08:40 by admin.

Messages
msg3136 (view) Author: salty-horse Date: 2008-02-05.20:57:26
Using latest stable 1.1.0pre1.

Whenever I "darcs put" my repository, the copy contains unrecorded changes.
At one point the original repository, I renamed a file from "plugin.cpp" to
"detection.cpp".

The unrecorded changes in the copy contain a copy of plugin.cpp to
detection.cpp, and a deletion of plugin.cpp

While it's trivial to do "darcs revert", this shouldn't happen at all.

Here is the repository where the problem occurs: http://ori.avtalion.name/repos/kom/

Unfortunately, I was unable to create an isolated test-case. To reproduce, just
"darcs get" and "darcs put" it somewhere else.
msg3148 (view) Author: markstos Date: 2008-02-06.15:41:05
Taking for triage.
msg3168 (view) Author: markstos Date: 2008-02-07.03:58:53
Salty-horse:

Good news: This bug has already been resolved in the unstable branch of darcs. I
did a "darcs get" and then a "put" of the repo you provided, and the result
included no unrecorded changes. 

    Mark
msg3213 (view) Author: salty-horse Date: 2008-02-07.20:35:12
I just compiled unstable 2.0.0pre3, and tried to "get" and then "put".
Unfortunately, still seeing the same unrecorded changes :(

Did you manage to reproduce it with the stable version? Maybe it's a problem
specific to my machine configuration and ghc+library versions (Ubuntu gutsy).
msg3215 (view) Author: droundy Date: 2008-02-07.20:48:11
salty-horse:

darcs put makes use of the darcs that is in your path, so this may actually be
fixed in darcs-unstable.  Is darcs-2 the "darcs" that is found in your path? If
not, could you try again with darcs-2 named "darcs" and in your path?

Thanks!
msg3218 (view) Author: salty-horse Date: 2008-02-07.21:05:23
You're right, droundy. It works now!

If the "fix" is simple, should it be backported to the stable 1.* branch?
msg3220 (view) Author: droundy Date: 2008-02-07.21:15:29
On Thu, Feb 07, 2008 at 09:05:24PM -0000, Ori Avtalion wrote:
> You're right, droundy. It works now!

Great! (and thanks for testing)

> If the "fix" is simple, should it be backported to the stable 1.* branch?

Possibly.  I suspect, however, that the fix isn't simple.  The relevant
code is completely rewritten in darcs2, so probably fixing this bug in the
stable branch would require tracking it down afresh.
-- 
David Roundy
Department of Physics
Oregon State University
History
Date User Action Args
2008-02-05 20:57:27salty-horsecreate
2008-02-06 15:41:06markstossetstatus: unread -> unknown
nosy: + markstos
messages: + msg3148
assignedto: markstos
2008-02-07 03:58:55markstossetstatus: unknown -> resolved-in-unstable
nosy: droundy, tommy, beschmi, kowey, markstos, salty-horse
messages: + msg3168
2008-02-07 20:35:14salty-horsesetnosy: droundy, tommy, beschmi, kowey, markstos, salty-horse
messages: + msg3213
2008-02-07 20:48:12droundysetnosy: droundy, tommy, beschmi, kowey, markstos, salty-horse
messages: + msg3215
2008-02-07 21:05:24salty-horsesetnosy: droundy, tommy, beschmi, kowey, markstos, salty-horse
messages: + msg3218
2008-02-07 21:15:31droundysetnosy: droundy, tommy, beschmi, kowey, markstos, salty-horse
messages: + msg3220
2008-09-04 21:32:20adminsetstatus: resolved-in-unstable -> resolved
nosy: + dagit
2009-08-06 17:53:19adminsetnosy: + jast, Serware, dmitry.kurochkin, darcs-devel, zooko, mornfall, simon, thorkilnaur, - droundy, salty-horse
2009-08-06 20:56:36adminsetnosy: - beschmi
2009-08-10 22:13:24adminsetnosy: + salty-horse, - darcs-devel, zooko, jast, Serware, mornfall
2009-08-11 00:06:11adminsetnosy: - dagit
2009-08-25 18:04:45adminsetnosy: + darcs-devel, - simon
2009-08-27 14:08:40adminsetnosy: tommy, kowey, markstos, darcs-devel, salty-horse, thorkilnaur, dmitry.kurochkin