Created on 2008-03-01.21:51:50 by micah, last changed 2009-09-04.10:56:07 by kowey.
msg3708 (view) |
Author: micah |
Date: 2008-03-01.21:51:48 |
|
I have a repository that I got from person 1.
Today, person 2 who also got the repository from person 1 sent me
patches to that repository, he also sent those patches to person 1 to apply there.
I ran darcs apply to add them to my repository.
There was an error in those patches, so I fixed it, and then ran darcs
record to record my changes.
Then I wanted to send those changes back to person 2, person 1 had not
integrated the original patches yet, but when he does, either I or
person 2 will send my fixes to him. So I ran darcs send
--to=person2@email.com and darcs asks me if I want to send the patches
that person2 sent to me and I recorded into the repository. Thats
silly, so I say 'n' to those patches. I went through those patches,
and then it said, 'You don't want to send any patches, and that's fine
with me!' without asking me about my fix.
It turned out that this is because my fix depends on those patches
that he sent me, but I wans't aware that darcs was being smart about
this. I resolved it by hitting 'w' and 'j' until I got to the correct
patch (note: these options were not listed as potential options!). And
then when i found it, I hit 'y' to send it.
Thanks!
Micah
|
msg3711 (view) |
Author: markstos |
Date: 2008-03-02.04:24:56 |
|
Micah,
Thanks for the report. I agree we could give the user better feedback in this
case. Do you have an idea how we would phrase this or behave better in this case?
Mark
|
msg3712 (view) |
Author: markstos |
Date: 2008-03-02.04:30:43 |
|
I also meant to reference a related discussion we had in 2005, which considers
the "w" for "wait and decide later" option:
http://lists.osuosl.org/pipermail/darcs-devel/2005-April/001734.html
If you had selected "w" instead of "n" here, you would have gotten the expected
result.
<thinks>
Maybe something like this would work. After selecting "n" for a patch with
dependencies, darcs could respond:
"unselecting this patch causes one or more dependent patches to automatically be
be unselected as well. Press 'n' again to confirm or "w" to wait and let darcs
select this patch automatically only if another patch depends on it."
Ugh. I don't know how to make that simpler.
|
msg8685 (view) |
Author: kowey |
Date: 2009-09-04.10:56:05 |
|
I think this is now resolved.
In the selection UI, darcs will say things like "Skipped send of 1 patch."
whenever it jumps over patches due to dependencies.
|
|
Date |
User |
Action |
Args |
2008-03-01 21:51:50 | micah | create | |
2008-03-02 03:45:06 | markstos | link | issue719 superseder |
2008-03-02 04:24:58 | markstos | set | priority: wishlist status: unread -> unknown messages:
+ msg3711 nosy:
+ markstos, micah, - micah title: You don't want to send any patches, and that's fine with me! -> wish: better response on "send" when no patches are selected due to dependencies |
2008-03-02 04:30:45 | markstos | set | nosy:
droundy, tommy, beschmi, kowey, markstos, micah messages:
+ msg3712 |
2008-08-13 02:04:32 | markstos | set | status: unknown -> deferred nosy:
+ dagit, micah, - micah |
2009-08-06 17:55:18 | admin | set | nosy:
+ jast, Serware, dmitry.kurochkin, darcs-devel, zooko, mornfall, simon, thorkilnaur, - droundy, micah |
2009-08-06 20:59:20 | admin | set | nosy:
- beschmi |
2009-08-10 22:16:38 | admin | set | nosy:
+ micah, - darcs-devel, zooko, jast, Serware, mornfall |
2009-08-11 00:08:04 | admin | set | nosy:
- dagit |
2009-08-25 18:06:31 | admin | set | nosy:
+ darcs-devel, - simon |
2009-08-27 14:02:45 | admin | set | nosy:
tommy, kowey, markstos, darcs-devel, thorkilnaur, micah, dmitry.kurochkin |
2009-09-04 10:56:07 | kowey | set | status: deferred -> resolved nosy:
tommy, kowey, markstos, darcs-devel, thorkilnaur, micah, dmitry.kurochkin messages:
+ msg8685 |
|