Created on 2008-03-12.21:16:14 by quick, last changed 2017-08-09.15:04:40 by bfrk.
msg3877 (view) |
Author: quick |
Date: 2008-03-12.21:16:11 |
|
I haven't had time to try reproducing this, but I'm reporting it to see if
anyone else has run into a similar issue.
In an active tree:
$ darcs pull
... pull some new patches ...
$ darcs optimize --reorder
This operation will make unrevert impossible!
Proceed? [yn]n
darcs failed: Cancelled to avoid unrevert catastrophe!
$ darcs unrevert
Backing up ./a/b/c/X-darcs-backup0
We have conflicts in the following files:
./a/b/c/X=
hunk ./a/b/c/X 20
- old stuff
+ new stuff
Shall I unrevert this change? (1/?) [ynWsfvpxdaqjkc], or ? for help: n
Skipped unrevert of 1 patch due to dependencies.
I'm about to write_unrevert.
Finished unreverting.
$
[Note that I didn't initially notice the conflicts report. Why would unrevert
encounter a conflict, especially when I haven't indicated I wanted anything
done yet?! The intention was just to see what was unrevertable... not to
actually effect any change. Since I didn't notice the conflict problem, I
moved forward to request the optimization since I didn't care about the above
change:]
$ darcs optimize --reorder
Done optimizing!
$
[Here is where I got wise: it reordered without asking about destroying
unrevertability! What happens if I do it again?]
$ darcs optimize --reorder
darcs: bug in get_extra commuting patch:
Wed Mar 5 15:11:46 MST 2008 Kevin Quick
* blah blah blah
$
[Wow, didn't expect that. Looking at the patch reported, it does not include
the a/b/c/X file that the unrevert had trouble with.]
$ darcs -v
2.0.0pre3 (unknown)
$ darcs --exact-version
darcs compiled on Feb 6 2008, at 23:31:19
unknown
$
[I have no idea why there was a conflict, although I assume that the stored
revert patch conflicted with some more recent patches applied to the tree. So
let's try cleaning up:]
$ darcs check
The repository is consistent!
$ darcs w -l
a .a/b/c/X-darcs-backup0
[Nothing seems to be wrong, but is that true?]
$ darcs optimize --reorder
darcs: bug in get_extra commuting patch:
Wed Mar 5 15:11:46 MST 2008 Kevin Quick
* blah blah blah
$
Yup, definite problems.
-KQ
-------------------------------------------------
This mail sent through IMP: http://horde.org/imp/
|
msg3948 (view) |
Author: droundy |
Date: 2008-03-21.15:50:47 |
|
Yes, this is definitely a real bug. It'll take time to track down, though. It
also doesn't show up on hashed-format repositories. The bug is in optimize
--reorder, which doesn't affect the working directory, and doesn't actually make
unrevert impossible. But we check on an intermediate stage of the reordering
(basically, we remove a bunch of patches and then add them back).
David
|
msg4451 (view) |
Author: kowey |
Date: 2008-05-02.09:13:44 |
|
Resurrecting this bug (now that darcs 2 is out). Kevin, I presume this is still
happening with the released darcs2?
I'm feeling a bit uneasy because I have seen a couple of reports of this
'get_extra commuting patch' error on the bug tracker, some of which involve darcs 2
|
msg8670 (view) |
Author: kowey |
Date: 2009-09-04.08:35:00 |
|
Hi Kevin,
Have you experienced anything like this with a more recent darcs?
Also: do you remember if there was anything unusual about this repository? Was
it tailorised for example or automatically generated in any way?
(Meanwhile: I'm also curious about why David said this only happens with
old-fashioned repositories).
It makes me very uncomfortable to do this, but we may have to mark this
presumed-dead.
|
msg19533 (view) |
Author: bfrk |
Date: 2017-08-09.15:04:38 |
|
I am closing this one. There is no reproducible test case, it was seen
ages ago, and we saw no follow-ups.
|
|
Date |
User |
Action |
Args |
2008-03-12 21:16:14 | quick | create | |
2008-03-21 15:50:49 | droundy | set | priority: bug status: unread -> deferred messages:
+ msg3948 nosy:
droundy, tommy, beschmi, kowey, quick |
2008-05-02 09:13:46 | kowey | set | status: deferred -> unknown nosy:
+ dagit messages:
+ msg4451 title: unrevert/reorder bug -> unrevert/reorder => bug in get_extra commuting patch (2.0.0pre3) |
2008-05-07 14:35:29 | kowey | set | status: unknown -> waiting-for nosy:
droundy, tommy, beschmi, kowey, dagit, quick assignedto: quick |
2009-08-06 17:56:43 | admin | set | nosy:
+ markstos, jast, Serware, dmitry.kurochkin, darcs-devel, zooko, mornfall, simon, thorkilnaur, - droundy, quick |
2009-08-06 21:00:28 | admin | set | nosy:
- beschmi |
2009-08-10 22:18:00 | admin | set | nosy:
+ quick, - markstos, darcs-devel, zooko, jast, Serware, mornfall |
2009-08-11 00:08:41 | admin | set | nosy:
- dagit |
2009-08-25 18:07:40 | admin | set | nosy:
+ darcs-devel, - simon |
2009-08-27 13:58:25 | admin | set | nosy:
tommy, kowey, darcs-devel, quick, thorkilnaur, dmitry.kurochkin |
2009-09-04 08:35:04 | kowey | set | nosy:
tommy, kowey, darcs-devel, quick, thorkilnaur, dmitry.kurochkin messages:
+ msg8670 title: unrevert/reorder => bug in get_extra commuting patch (2.0.0pre3) -> optimize --reorder => bug in get_extra commuting patch (2.0.0pre3) |
2017-08-09 15:04:40 | bfrk | set | status: waiting-for -> given-up messages:
+ msg19533 |
|