i!

Few days ago I built darcs by pulling latest patches from 'unstable' on my
x86_64 box.

Attempt to push some patches from laptop to desktop results in:

gour@nitai ~/d/emacs> darcs push -v gour@gaura-nitai.no-ip.org:darcs/emacs
darcs: bug in get_extra commuting patch:
Mon Feb 11 08:51:15 CET 2008  dev@atmarama.org
  * new version of GnusSync

gour@nitai ~> darcs --exact-version
darcs compiled on Mar 12 2008, at 14:36:06
unknown

gour@nitai ~/org> ghc -v
Glasgow Haskell Compiler, Version 6.8.2, for Haskell 98, stage 2 booted by GHC
version 6.8.1

I am submitting patch file which triggers the bug.

Sincerely,
Gour

Attachments

• f599716922dedc6fb9d45dd0dfcb5bc404bfc0db

Gour,

If you were using darcs 1, then I believe this is fixed with darcs 2. If you
were using a recent Darcs 2, then please re-open this bug and we can investigate
further.

Hi!

Excuse me for not mentioning it happens with darcs-2

Gour,

Thanks for the follow-up. So both repos were probably in the in the old format
or the "hashed" format at the time? 

If you run "darcs convert" one the repo with more patches, and then use "darcs
get" and "obliterate" to create the smaller branch, is the bug still triggered
then? 

Using both the Darcs-2 binary and the new --darcs-2 repo format may be necessary
to avoid the issue. 

I'm marking this as "deferred" now while we wait for your further feedback.

>>>>> "Mark" == Mark Stosberg <bugs@darcs.net> writes:

Mark> Thanks for the follow-up. So both repos were probably in the in
Mark> the old format or the "hashed" format at the time?

Yes, both repos were in the old format and now both are in new format.

Mark> If you run "darcs convert" one the repo with more patches, and
Mark> then use "darcs get" and "obliterate" to create the smaller
Mark> branch, is the bug still triggered then?

Heh, both repos are converted.

Mark> Using both the Darcs-2 binary and the new --darcs-2 repo format
Mark> may be necessary to avoid the issue.

Both repos are in --darcs-2 repo format.

Mark> I'm marking this as "deferred" now while we wait for your further
Mark> feedback.

OK. Yesterday I emailed both repos to droundy.

Sincerely,
Gour

-- 

Gour  | Zagreb, Croatia  | GPG key: C6E7162D
----------------------------------------------------------------

Thanks for the feedback, Gour. I'll assume that both repos were converted
through one use of "darcs convert", not running "darcs convert" separately on
each repo. 

We can wait to see what result David finds then. In the meantime, I have
upgraded the bug to "urgent" and am suggesting it be looked into before the
Darcs 2 release. 

  Mark

Hi Gour,

I'm still not entirely clear how you got these repositories.  Did you run darcs
convert once on each repository?

Thanks!

David

>>>>> "David" == David Roundy <bugs@darcs.net> writes:

David> I'm still not entirely clear how you got these repositories.  Did
David> you run darcs convert once on each repository?

Yes...and then tried to push from one (laptop) to the other.

Sincerely,
Gour

-- 

Gour  | Zagreb, Croatia  | GPG key: C6E7162D
----------------------------------------------------------------

Okay, in that case this is a documentation bug.  You can't run convert on two
related repositories without causing trouble.  I've added a message to this
effect (possibly unclear?), which I'll interpret as resolving this bug.

On Tue, Mar 18, 2008 at 07:44:27PM +0100, Gour wrote:
> >>>>> "Mark" == Mark Stosberg <bugs@darcs.net> writes:
> 
> Mark> Thanks for the feedback, Gour. I'll assume that both repos were
> Mark> converted through one use of "darcs convert", not running "darcs
> Mark> convert" separately on each repo.
> 
> No. I run 'convert' on each repo separately and do not see why this is
> problematic nor see any note about it in the wiki?

If you visit the wiki you will indeed find a note about this.  Visit the
following URL and then search for convert, and you'll find a warning right
there.

http://wiki.darcs.net/index.html/DarcsTwo

I suppose the warning is not as strong as it should be:

"Moreover, you should ideally only perform this command once per project,
as the conversion is not reversible, and its result is dependent on the
order of patches in your repository. Of course, you can experiment all you
like, but projects should switch to darcs-2 format in unison, and only
after the final release of darcs 2."
-- 
David Roundy
Department of Physics
Oregon State University

Here's how I updated the wiki:

"The convert command runs slowly. Perform this command once per project, not
once for each repo. The conversion is not reversible and its result is dependent
on the order of patches in your repository. Projects should switch to darcs-2
format in unison. While testers and early adopters may switch now, the safe
option is to switch after the final release of darcs 2."

Since multiple people have made this mistake, the built-in docs for "darcs
convert" perhaps should also be firmer and clearer about this point.