darcs

Issue 761 darcs pull doesn't check date pattern syntax soon enough

Title darcs pull doesn't check date pattern syntax soon enough
Priority bug Status resolved
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, kowey, thorkilnaur, tim, tommy
Assigned To
Topics

Created on 2008-03-25.21:55:07 by tim, last changed 2009-08-27.14:09:30 by admin.

Messages
msg4012 (view) Author: tim Date: 2008-03-25.21:55:05
In a clean GHC repository (downloadable from
http://darcs.haskell.org/ghc-HEAD-2007-12-16-ghc-corelibs-testsuite.tar.bz2), I did:

darcs pull -a --match "before 2008-03-24"

darcs ran for twenty minutes, then spit out:

**********************
darcs: Invalid --match pattern 'before 2008-03-24'.
    "match" (line 1, column 1):
    unexpected "b"
    expecting match rule

Perhaps darcs could check the syntax of the pattern before getting patches, so
that the user could fix their error without waiting twenty minutes for patches
to download.
msg4013 (view) Author: tim Date: 2008-03-25.21:55:45
darcs 1.0.9rc1, btw
msg4024 (view) Author: droundy Date: 2008-03-26.14:22:22
I'm pushing a fix for this.  When it arrives, could you check that it actually
works, Tim?  Thanks for the bug report!

David
msg4025 (view) Author: droundy Date: 2008-03-26.14:38:39
Never mind with testing this, Tim (unless you'd like to, which would always be
appreciated).  I noticed that you were reporting on darcs 1.0.9rc1, and figured
you'd probably rather not bother compiling the latest darcs-unstable, so I wrote
up a nice little test script for this problem.
msg4031 (view) Author: droundy Date: 2008-03-26.17:09:59
Okay, looks like our automatic closing of bugs is acting up again.  :(
msg4034 (view) Author: tim Date: 2008-03-26.17:18:13
Thanks for the fix. You're right that I would prefer not to get involved in
compiling the latest darcs at this precise moment, but whenever I get around to
upgrading (which might be never), I'll yell if it doesn't work :-)
History
Date User Action Args
2008-03-25 21:55:07timcreate
2008-03-25 21:55:46timsetstatus: unread -> unknown
nosy: tommy, beschmi, kowey, tim
messages: + msg4013
2008-03-26 14:22:23droundysetnosy: + droundy
messages: + msg4024
2008-03-26 14:38:41droundysetnosy: droundy, tommy, beschmi, kowey, tim
messages: + msg4025
2008-03-26 17:10:01droundysetstatus: unknown -> resolved-in-unstable
nosy: droundy, tommy, beschmi, kowey, tim
messages: + msg4031
2008-03-26 17:18:14timsetnosy: droundy, tommy, beschmi, kowey, tim
messages: + msg4034
2008-09-04 21:33:01adminsetstatus: resolved-in-unstable -> resolved
nosy: + dagit
2009-08-06 17:57:26adminsetnosy: + markstos, jast, Serware, dmitry.kurochkin, darcs-devel, zooko, mornfall, simon, thorkilnaur, - droundy, tim
2009-08-06 21:01:04adminsetnosy: - beschmi
2009-08-10 22:18:44adminsetnosy: + tim, - markstos, darcs-devel, zooko, jast, Serware, mornfall
2009-08-11 00:08:57adminsetnosy: - dagit
2009-08-25 18:08:04adminsetnosy: + darcs-devel, - simon
2009-08-27 14:09:30adminsetnosy: tommy, kowey, darcs-devel, tim, thorkilnaur, dmitry.kurochkin