darcs

Issue 799 should we accept 'Enter' as a response in interactive mode?

Title should we accept 'Enter' as a response in interactive mode?
Priority wishlist Status wont-fix
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, ertai, kowey, thorkilnaur, tommy
Assigned To
Topics

Created on 2008-04-17.18:07:25 by dagit, last changed 2009-10-24.00:04:47 by admin.

Files
File name Uploaded Type Edit Remove
unnamed dagit, 2008-04-17.18:07:23 text/html
unnamed dagit, 2008-04-25.18:05:25 text/html
Messages
msg4248 (view) Author: dagit Date: 2008-04-17.18:07:23
When doing a pull, the way to accept the default is by hitting space not
enter.

We should consider allowing enter to be a valid response.  Was the current
behavior done to prevent accidental interactions?

Thanks,
Jason
Attachments
msg4249 (view) Author: ertai Date: 2008-04-17.18:23:32
Excerpts from Darcs Bugs's message of Thu Apr 17 18:07:25 UTC 2008:
> 
> New submission from Jason Dagit <dagit@codersbase.com>:
> 
> When doing a pull, the way to accept the default is by hitting space not
> enter.
> 
> We should consider allowing enter to be a valid response.  Was the current
> behavior done to prevent accidental interactions?

I think so, and it actually prevent me from unwanted key presses.
msg4341 (view) Author: kowey Date: 2008-04-25.17:25:26
Is this a list-worthy discussion?  Or Jason, are you happy with just pressing space?

Enabling enter should just consist of modifying Darcs.Utils.promptCharFancy

I have no opinion on the matter.
msg4349 (view) Author: dagit Date: 2008-04-25.18:05:25
On Fri, Apr 25, 2008 at 10:25 AM, Eric Kow <bugs@darcs.net> wrote:

>
>
> Is this a list-worthy discussion?  Or Jason, are you happy with just
> pressing space?

Tough call.  This is bike-shed material.  Probably safest to not involve the
world in the discussion.

One option is to leave the UI how it is (people don't seem to complain often
and I know enough about darcs that I can just deal with it and not really be
bothered).

How about I mark this as "won't fix" and it will stand in the bug database
as a reminder that things could easily be put this way and gives people
something to reference if they want this functionality.

Jason
Attachments
msg4350 (view) Author: dagit Date: 2008-04-25.18:06:26
We won't fix this until lots of people request it.
History
Date User Action Args
2008-04-17 18:07:25dagitcreate
2008-04-17 18:23:34ertaisetstatus: unread -> unknown
nosy: + darcs-devel, ertai
messages: + msg4249
2008-04-20 19:04:55zookolinkissue800 superseder
2008-04-25 17:25:27koweysetpriority: wishlist
nosy: - darcs-devel
messages: + msg4341
title: Pressing enter when prompted to pull patches is an invalid response -> should we accept 'Enter' as a response in interactive mode?
2008-04-25 18:05:27dagitsetfiles: + unnamed
nosy: tommy, beschmi, kowey, dagit, ertai
messages: + msg4349
2008-04-25 18:06:28dagitsetstatus: unknown -> wont-fix
nosy: tommy, beschmi, kowey, dagit, ertai
messages: + msg4350
2009-08-06 21:02:37adminsetnosy: + dmitry.kurochkin, simon, thorkilnaur, - beschmi
2009-08-11 00:10:24adminsetnosy: - dagit
2009-08-25 18:10:00adminsetnosy: + darcs-devel, - simon
2009-08-27 13:57:55adminsetnosy: tommy, kowey, darcs-devel, thorkilnaur, ertai, dmitry.kurochkin
2009-10-23 22:39:45adminsetnosy: + nicolas.pouillard, - ertai
2009-10-24 00:04:47adminsetnosy: + ertai, - nicolas.pouillard