There's probably a good reason for this, but why doesn't the configure script
check for libcurl pipelining even when the user *doesn't* specify
"--with-curl-pipelining"?

The reason is simple - curl pipelining code (at least part of it required by
darcs) is new and considered experimental feature in libcurl. I did not want to
break "darcs get" for everybody that is why it is turned off by default.

Perhaps now, after some time has passed and no one complains (or no one uses?),
it can be enabled by default.

I'm using --with-curl-pipelining.  You can be sure that I will submit a bug
report if it doesn't work like I want it to.  ;-)

Regards,

Zooko, unhesitant submitter of bug reports

Just to chip in - I had thought curl pipelining was tested for and enabled by
default from my reading of configure.ac, but I guess I was wrong.

Anyway, I've enabled it as well. In a bunch of test gets from darcs.haskell.org,
it seems to be running as normal (perhaps a little bit faster than without, but
nothing I could really put my finger on).

Like Zooko, I shall definitely keep an eye out for bugs.

I think this is just because curl pipelining has received almost no
testing due to the extremely-recent version of curl required (I
certainly haven't tried it).  Have you been able to try it out?

David

On Thu, May 8, 2008 at 6:17 PM, Zooko <bugs@darcs.net> wrote:
> There's probably a good reason for this, but why doesn't the configure script
> check for libcurl pipelining even when the user *doesn't* specify
> "--with-curl-pipelining"?

On May 9, 2008, at 5:28 AM, David Roundy wrote:

> I think this is just because curl pipelining has received almost no
> testing due to the extremely-recent version of curl required (I
> certainly haven't tried it).  Have you been able to try it out?

As of yesterday I have it running on all of our important servers at  
allmydata, but it hasn't been much tested yet.

Regards,

Zooko

What kind of time frame are we looking at here?  If nobody suggests one, I
propose we wait a month before we enable the configure check, i.e. that we defer
this item until 2008-06-14

What's the current status on this? It's been a while, and I don't think I've
seen any bugs attributed to pipelining besides #920
http://bugs.darcs.net/issue920 and it looks like it could be avoided by
requiring a higher version of curl?

Could you submit a patch so that we have a flag to disable pipelining (enabling
it by default)?  Thanks!

I guess it would make sense to try it.  This way, we get more reports of what's
going on, at least.

If you do not mind I would like to make the patch myself :) I just need to find
out a way to disable libwww pipelining...

Regards,
  Dmitry

I'm putting this on the "2.1" release list since it is a nice performance boost
that is close to being wrapped up.

The bug is fixed in the latest darcs.