darcs

Issue 840 Windows: spurious test suite bugs

Title Windows: spurious test suite bugs
Priority bug Status resolved
Milestone 2.0.x Resolved in
Superseder Nosy List Serware, darcs-devel, dmitry.kurochkin, kowey, thorkilnaur, tommy, zooko
Assigned To zooko
Topics

Created on 2008-05-09.07:40:26 by kowey, last changed 2010-06-15.21:20:26 by admin.

Messages
msg4586 (view) Author: kowey Date: 2008-05-09.07:40:25
http://buildbot.darcs.net/buildbot-darcs/builders/zooko windows
Windows-XP i386/builds/57/steps/test/logs/stdio

Running shell tests on hashed repositories...
-rThe system cannot find the file specified.

All tests successful!
Done running tests on hashed repositories...
Running shell tests on old-fashioned repositories...
-rThe system cannot find the file specified.
msg4617 (view) Author: zooko Date: 2008-05-09.17:07:44
I'm working on this bug.  I think that what is going on is that the rules to
implement the "make test" targets depend on a lot of unix-like functionality, e.g.:

test_shell_hashed:     darcs
	$(call shell_harness,hashed,\
	 echo ALL --hashed >> .darcs/defaults,cat)

Where shell_harness is:

shell_harness=$(call harness,$1,$2,$3,shell,sh,$(SHELL_HARNESS))

where harness is:

define harness
	@echo Running $4 tests on $1 repositories...
	@rm -rf tests-$4-$1.dir && cp -R tests tests-$4-$1.dir
	@cd tests-$4-$1.dir && rm -rf .darcs; mkdir .darcs;\
	 $2;\
	 if [ -r $(TEST_FILTER_FILE) ];\
	 then grep "\.$5" $(TEST_FILTER_FILE) | grep -v '^#' | $3 | xargs $6; \
	 else ls *.$5 | sort -r | $3 | xargs $6; fi
	@echo Done running tests on $1 repositories...
endef

This is okay in principle -- it just means we require cygwin to run the tests,
which is fine with me -- but I need to figure out what part of it isn't working
on Windows...
msg4620 (view) Author: zooko Date: 2008-05-09.19:45:20
Okay, now it is at least running well enough to start the test script.  The
trick was to change my Windows "%path%" environment variable to put
c:\cygwin\usr\bin earlier than c:\WINDOWS\System32, so that the "sort.exe" that
gets called by GNU make when it wants to launch a test run is unix sort.exe and
not Windows sort.exe.

Now there are a bunch of test failures, some of which no doubt need to be fixed
"on my end", such as further configuration of my %path%, others of which no
doubt need to be fixed "on the darcs end", such as by changing darcs to work
better on Windows.

That's my assumption anyway.  We'll see...
msg6381 (view) Author: zooko Date: 2008-10-21.21:53:56
Thanks to kowey and others, this has been fixed!
History
Date User Action Args
2008-05-09 07:40:26koweycreate
2008-05-09 15:49:48zookosetpriority: bug
nosy: tommy, beschmi, kowey, zooko, dagit
2008-05-09 15:50:03zookosetnosy: tommy, beschmi, kowey, zooko, dagit
assignedto: zooko
2008-05-09 17:07:46zookosetstatus: unread -> unknown
nosy: tommy, beschmi, kowey, zooko, dagit
messages: + msg4617
2008-05-09 19:45:22zookosetnosy: tommy, beschmi, kowey, zooko, dagit
messages: + msg4620
2008-05-21 15:27:09koweylinkissue841 superseder
2008-05-21 15:28:51koweysettopic: + Target-2.0
nosy: + Serware, droundy
title: buildbot tests on Windows pass for the wrong reason -> Windows: spurious test suite bugs
2008-10-21 21:53:58zookosetstatus: unknown -> resolved
nosy: + dmitry.kurochkin, simon, thorkilnaur
messages: + msg6381
2009-08-06 17:58:46adminsetnosy: + markstos, jast, darcs-devel, mornfall, - droundy
2009-08-06 21:04:17adminsetnosy: - beschmi
2009-08-10 22:20:24adminsetnosy: - markstos, darcs-devel, jast, mornfall
2009-08-11 00:12:50adminsetnosy: - dagit
2009-08-25 17:31:40adminsetnosy: + darcs-devel, - simon
2009-08-27 14:13:00adminsetnosy: tommy, kowey, darcs-devel, zooko, thorkilnaur, dmitry.kurochkin, Serware
2009-10-23 22:43:19adminsetnosy: + serware, - Serware
2009-10-23 23:29:17adminsetnosy: + Serware, - serware
2010-06-15 21:20:25adminsetmilestone: 2.0.x
2010-06-15 21:20:26adminsettopic: - Target-2.0