Issue 85: Shall I record this patch?" -> "Shall I record this hunk/mv/del/add? - Darcs bug tracker

Title	Shall I record this patch?" -> "Shall I record this hunk/mv/del/add?
Priority	bug	Status	resolved
Milestone		Resolved in
Superseder		Nosy List	darcs-devel, dmitry.kurochkin, kowey, taral, thorkilnaur, tommy, zooko
Assigned To		Topics

Created on 2006-01-06.20:20:10 by zooko, last changed 2009-08-27.13:47:14 by admin.

Messages
msg318 (view)	Author: zooko	Date: 2006-01-06.20:20:09
It's confusing that darcs says "Shall I record this patch?" when it isn't talking about a patch, but a hunk. I'm walking a new user through darcs right now and he stumbled on this.
msg319 (view)	Author: taral	Date: 2006-01-06.21:20:35
How about "Shall I include this change?"
msg326 (view)	Author: zooko	Date: 2006-01-07.15:45:37
Sounds good!
msg328 (view)	Author: tommy	Date: 2006-01-07.22:55:24
I agree with this. I just want to add that the interface in SelectChanges.lhs could do with a rewrite to make it more flexible. It's not possible to just make the suggested change in any "nice" way as it is (although it is of course very easy to hack it in with a simple if-then-else).
msg329 (view)	Author: tommy	Date: 2006-01-07.22:59:38
On Fri, Jan 06, 2006 at 09:20:35PM +0000, JP Sugarbroad wrote: > How about "Shall I include this change?" There's a convention that the "Shall I ..." prompts use the command name (it's actually coded that way), so I suggest "Shall I record this change?" to make it not divert from the other commands.
msg330 (view)	Author: tommy	Date: 2006-01-08.01:03:54
On Sat, Jan 07, 2006 at 10:55:24PM +0000, Tommy Pettersson wrote: > It's not > possible to just make the suggested change in any "nice" > way as it is I'll take that back, and send a patch to darcs-unstble that makes the change.
msg645 (view)	Author: tommy	Date: 2006-05-13.18:10:26
fixed in 1.0.7 by: Fri Jan 13 21:38:29 CET 2006 Tommy Pettersson <ptp@lysator.liu.se> * call unnamed patches "changes" in interactive patch selection dialogue

History
Date	User	Action	Args
2006-01-06 20:20:10	zooko	create
2006-01-06 21:20:35	taral	set	status: unread -> unknown nosy: + taral messages: + msg319
2006-01-07 15:45:38	zooko	set	nosy: droundy, tommy, taral, zooko messages: + msg326
2006-01-07 22:55:24	tommy	set	nosy: droundy, tommy, taral, zooko messages: + msg328
2006-01-07 22:59:38	tommy	set	nosy: droundy, tommy, taral, zooko messages: + msg329
2006-01-08 01:03:54	tommy	set	nosy: droundy, tommy, taral, zooko messages: + msg330
2006-01-13 22:14:39	jch	set	status: unknown -> resolved-in-unstable nosy: droundy, tommy, taral, zooko
2006-04-08 00:24:39	tommy	set	status: resolved-in-unstable -> resolved-in-stable nosy: droundy, tommy, taral, zooko
2006-05-13 18:10:26	tommy	set	status: resolved-in-stable -> resolved nosy: droundy, tommy, taral, zooko messages: + msg645
2009-08-06 17:42:25	admin	set	nosy: + markstos, jast, Serware, dmitry.kurochkin, darcs-devel, dagit, mornfall, simon, kowey, beschmi, thorkilnaur, - droundy, taral
2009-08-06 20:47:55	admin	set	nosy: - beschmi
2009-08-10 22:20:42	admin	set	nosy: + taral, - markstos, darcs-devel, jast, dagit, Serware, mornfall
2009-08-25 17:55:45	admin	set	nosy: + darcs-devel, - simon
2009-08-27 13:47:14	admin	set	nosy: tommy, kowey, taral, darcs-devel, zooko, thorkilnaur, dmitry.kurochkin