darcs

Issue 854 how does darcs deal with 'empty' commands (EDITOR, PAGER)

Title how does darcs deal with 'empty' commands (EDITOR, PAGER)
Priority bug Status resolved
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, kowey, ppessi, thorkilnaur, tommy
Assigned To ppessi
Topics

Created on 2008-05-15.15:28:09 by kowey, last changed 2009-08-27.14:09:56 by admin.

Messages
msg4714 (view) Author: kowey Date: 2008-05-15.15:28:08
Potential bug: setting one of the command environment variables (DARCS_PAGER)
could cause bad things to happen (running the first argument as the command
since the command itself is the empty string?).  I think it should be fine, and
that System.Process.runProcess does what we want anyway (for example, we're not
using System.Cmd)... but thought I should note it down anyway
msg4717 (view) Author: ppessi Date: 2008-05-15.16:36:27
The following patch already implemts the feature in unstable.

Mon May 12 18:43:47 EEST 2008  Pekka Pessi <pekka.pessi@nokia.com>
  * pipeDocToPager runs no pager if pager is "".
  
  Darcs does not run pager if DARCS_PAGER environment variable has empty value
  (or PAGER, if DARCS_PAGER is not set).
  
  This is like man uses MANPAGER or PAGER environment variables.
History
Date User Action Args
2008-05-15 15:28:09koweycreate
2008-05-15 16:36:29ppessisetstatus: unread -> resolved-in-unstable
nosy: + ppessi
messages: + msg4717
assignedto: ppessi
2008-09-04 21:33:26adminsetstatus: resolved-in-unstable -> resolved
nosy: tommy, beschmi, kowey, dagit, ppessi
2009-08-06 21:04:51adminsetnosy: + dmitry.kurochkin, simon, thorkilnaur, - beschmi
2009-08-11 00:13:52adminsetnosy: - dagit
2009-08-25 18:10:59adminsetnosy: + darcs-devel, - simon
2009-08-27 14:09:56adminsetnosy: tommy, kowey, darcs-devel, ppessi, thorkilnaur, dmitry.kurochkin