darcs

Issue 862 Output patch format depends on patch origin for hashed repos!

Title Output patch format depends on patch origin for hashed repos!
Priority wishlist Status chatting
Superseder Nosy List Serware, beschmi, btcoburn, dagit, droundy, kowey, simon, thorkilnaur, tommy
Assigned To Topics Darcs2

Created on 2008-05-18.17:37:12 by btcoburn, last changed 2008-09-28.20:50:00 by admin.

Messages (mbox)
msg4751 (view) Author: btcoburn Date: 2008-05-18.17:37:09
Sometimes patches with one "atomic change" have curly braces and sometimes they
don't. Specificaly, patches imported with 'darcs get --hashed' retain curly
braces, while patches newly created in the hashed repository are not represented
with curly braces.

See the following example. The first two patches were imported with 'darcs get
--hashed', while the second two patches were created directly in the hashed
repository.

[test setup
test@example.com**20080518153437] {
addfile ./baz
hunk ./baz 1
+test setup again
}

[patch format test
test@example.com**20080518153518] {
hunk ./baz 2
+darcs1 test one hunk
+
}

[local one hunk
test@example.com**20080518173216] hunk ./baz 3
+
+one hunk locally recorded in darcs2

[two hunk local patch
test@example.com**20080518173647] {
hunk ./baz 1
-test setup again
+test setup
hunk ./baz 4
-one hunk locally recorded in darcs2
+two hunk locally recorded in darcs2
}

Darcs 2.0.0 stable release binary for MacOS X. Patches were listed with 'darcs
send -o'.
msg4752 (view) Author: kowey Date: 2008-05-18.17:50:22
Jason: any chance this could be serious?
msg4761 (view) Author: kowey Date: 2008-05-19.09:00:22
Ok, I'm going to escalate because I can't tell if this is worrisome or not, and
I'd rather be safe than sorry.  David: is there any need to be worried about
this bug?
msg4771 (view) Author: daveroundy Date: 2008-05-19.14:56:18
Do you consider this a bug? If so, why?

David
msg4773 (view) Author: kowey Date: 2008-05-19.15:04:21
I guess the potential cause for concern was something about hashes being
different for otherwise the same patch created under the different circumstances
(sort of the opposite problem of a collision).  It didn't seem like we really
relied on this for anything in particular, but thought it was worth checking :-)

Otherwise, I think why Ben considers it to be a bug is because it makes it
harder for outside tools be parsing darcs patch files, definitely a lower
priority than the above.

Browse related patches: unstable | stable

History
Date User Action Args
2008-05-18 17:37:12btcoburncreate
2008-05-18 17:50:23koweysetstatus: unread -> chatting
nosy: + kowey
messages: + msg4752
2008-05-19 09:00:23koweysetnosy: + droundy
messages: + msg4761
2008-05-19 13:56:10koweylinkissue863 superseder
2008-05-19 13:56:28koweyunlinkissue863 superseder
2008-05-19 14:56:20daveroundysetnosy: + daveroundy
messages: + msg4771
2008-05-19 14:58:26droundysetpriority: bug -> not-our-bug
nosy: droundy, tommy, beschmi, kowey, dagit, btcoburn, daveroundy, Serware
2008-05-19 15:00:14droundysetpriority: not-our-bug -> wishlist
nosy: droundy, tommy, beschmi, kowey, dagit, btcoburn, daveroundy, Serware
2008-05-19 15:04:23koweysetnosy: droundy, tommy, beschmi, kowey, dagit, btcoburn, daveroundy, Serware
messages: + msg4773
2008-09-28 20:50:00adminsetnosy: + simon, thorkilnaur, - daveroundy