darcs

Issue 93 I wish ask-for-deps would exclude already depended-on

Title I wish ask-for-deps would exclude already depended-on
Priority not-our-bug Status resolved
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, kowey, thorkilnaur, tommy, zooko
Assigned To
Topics

Created on 2006-01-12.05:59:24 by zooko, last changed 2009-08-27.13:46:18 by admin.

Messages
msg354 (view) Author: zooko Date: 2006-01-12.05:59:23
When interactively browsing patches during ask-for-deps, it should exclude
patches which I already depend on because they are depended on by patches that
I've already selected.  Also, of course, it should exclude patches that it
already depends on because they are syntactically required.

For some reason ask-for-deps is extremely slow (http://bugs.darcs.net/issue89)
even though it doesn't do these things for me.  Actually, maybe there is
another bug here: it says it is going to ask me for deps on 779 patches, when
there are actually 1375 in the repo.  Has it already calculated the maximum
number which I could possibly choose to depend on or something?

Regards,

Zooko
msg355 (view) Author: tommy Date: 2006-01-12.10:57:07
This sounds like a regression bug.  --ask-deps was broken in
some very old version of darcs but got fixed and then worked as
it should (not asking about explicit or forced dependencies).
It however always has been slow with many/complicated
dependencies.

I did some simple testing with both stable and unstable,
but couldn't see any faulty behavior.  Can you produce a test
case or supply the repo?
msg356 (view) Author: zooko Date: 2006-01-12.15:28:11
My apologies -- I must have misunderstood something last night.  In the morning
light, --ask-deps does indeed excluded already-depended-on.

Also this explains why it is so darn slow.

resolved.  bug reporter mistake.

Oh, I see at least partially why I was confused last night -- it doesn't update
the count of patches remaining as I add deps.
msg357 (view) Author: zooko Date: 2006-01-12.15:37:32
resolved
History
Date User Action Args
2006-01-12 05:59:24zookocreate
2006-01-12 10:57:08tommysetstatus: unread -> unknown
nosy: droundy, tommy, zooko
messages: + msg355
2006-01-12 15:28:12zookosetnosy: droundy, tommy, zooko
messages: + msg356
2006-01-12 15:37:32zookosetstatus: unknown -> resolved
nosy: droundy, tommy, zooko
messages: + msg357
2009-08-06 17:33:58adminsetnosy: + markstos, jast, Serware, dmitry.kurochkin, darcs-devel, dagit, mornfall, simon, kowey, beschmi, thorkilnaur, - droundy
2009-08-06 20:48:03adminsetnosy: - beschmi
2009-08-10 22:21:33adminsetnosy: - markstos, darcs-devel, jast, dagit, Serware, mornfall
2009-08-25 17:48:39adminsetnosy: + darcs-devel, - simon
2009-08-27 13:46:18adminsetnosy: tommy, kowey, darcs-devel, zooko, thorkilnaur, dmitry.kurochkin