darcs

Issue 944 darcs can corrupt inventory of a partial repository

Title darcs can corrupt inventory of a partial repository
Priority bug Status wont-fix
Milestone Resolved in
Superseder Nosy List Serware, darcs-devel, dmitry.kurochkin, kowey, thorkilnaur, tommy, wlux
Assigned To
Topics Partial, Regression

Created on 2008-07-02.16:23:51 by wlux, last changed 2014-03-17.01:16:54 by gh.

Files
File name Uploaded Type Edit Remove
bug.sh wlux, 2008-07-02.16:23:44 application/octet-stream
Messages
msg5171 (view) Author: wlux Date: 2008-07-02.16:23:44
Hello,

I have encountered a bug where darcs 2.0.2 writes out an incorrect  
inventory when undoing changes or performing darcs optimize in a  
repository checked out with darcs get --partial. This seems to happen  
only when multiple checkpoints are present. In particular, the  
inventory written out after these operations lists *all* patches of  
the repository rather than only the patches since the checkpoint.  
This may lead to problems with future commands and darcs check.

The test script attached below reproduces the problem. In this case  
it was necessary to introduce three check points, but I have observed  
the issue in a real world repository with only two checkpoints, too.

Regards
Wolfgang
Attachments
msg5179 (view) Author: kowey Date: 2008-07-04.08:46:27
Assigning to myself to reproduce.  Thanks for the test script!

Please feel free to submit it as a patch (we have a bugs/ directory for
currently known reproducible bugs).

Also, is this a regression from darcs 1.0.9 to your knowledge?
msg5182 (view) Author: wlux Date: 2008-07-04.09:16:32
Eric Kow wrote:

> Eric Kow <eric.kow@gmail.com> added the comment:
>
> Assigning to myself to reproduce.  Thanks for the test script!
>
> Please feel free to submit it as a patch (we have a bugs/ directory  
> for
> currently known reproducible bugs).
>
> Also, is this a regression from darcs 1.0.9 to your knowledge?

Definitely not, the test script works fine with 1.0.9 and I never had  
problems with partial repositories before darcs2
msg5183 (view) Author: kowey Date: 2008-07-04.09:19:20
Hi,

I'm sorry, but I just got confused by that response!  You said that it was
working fine with darcs 1.0.9 and now is no longer working with darcs 2, so that
*is* a regression, right?  Thanks!
msg5184 (view) Author: wlux Date: 2008-07-05.08:11:23
Eric Kow wrote:

> Eric Kow <eric.kow@gmail.com> added the comment:
>
> Hi,
>
> I'm sorry, but I just got confused by that response!  You said that  
> it was
> working fine with darcs 1.0.9 and now is no longer working with  
> darcs 2, so that
> *is* a regression, right?  Thanks!

Blush. Of course it is a regression.
Don't know how I managed to write anything different ...
msg5500 (view) Author: kowey Date: 2008-08-14.06:43:04
I've submitted your test case to the repository.  Sorry for the delay!
msg8246 (view) Author: kowey Date: 2009-08-18.12:18:15
I can confirm that this still fails with darcs 2.3.
The test issue944_partial_inventory is in the repo, so all we need is a diagnosis.
The fact that this is a regression from darcs 1 should be a pretty big clue.
msg15859 (view) Author: gh Date: 2012-07-09.23:14:18
As darcs no longer writes in old-fashioned repositories, the issue is 
"wont-fix".
History
Date User Action Args
2008-07-02 16:23:51wluxcreate
2008-07-04 08:45:03koweylinkissue945 superseder
2008-07-04 08:46:34koweysetstatus: unread -> unknown
priority: bug
title: Bug: darcs can corrupt inventory of a partial repository -> darcs can corrupt inventory of a partial repository
nosy: + Serware, wlux, kowey, - wlux
messages: + msg5179
topic: + Darcs2, IncludesExampleOrTest
assignedto: kowey
2008-07-04 09:16:36wluxsetnosy: + serware
messages: + msg5182
2008-07-04 09:19:29koweysettopic: + Regression
nosy: + serware, - serware
messages: + msg5183
2008-07-05 08:11:27wluxsetnosy: + serware
messages: + msg5184
2008-08-14 06:43:06koweysetnosy: + darcs-devel, simon, - serware
messages: + msg5500
assignedto: kowey ->
2008-08-14 15:30:56simonsetnosy: - simon
2009-08-06 21:08:57adminsetnosy: + dmitry.kurochkin, simon, thorkilnaur, - beschmi
2009-08-11 00:18:04adminsetnosy: - dagit
2009-08-18 12:18:24koweysetstatus: unknown -> needs-reproduction
nosy: tommy, kowey, darcs-devel, simon, thorkilnaur, dmitry.kurochkin, serware, Serware, wlux
topic: + Confirmed, Partial, - Darcs2
messages: + msg8246
2009-08-25 18:13:01adminsetnosy: - simon
2009-08-27 14:26:41adminsetnosy: tommy, kowey, darcs-devel, thorkilnaur, dmitry.kurochkin, serware, Serware, wlux
2009-10-23 22:43:33adminsetnosy: - Serware
2009-10-23 23:27:46adminsetnosy: + Serware, - serware
2012-07-09 23:14:21ghsettopic: - Confirmed, IncludesExampleOrTest
messages: + msg15859
2014-03-17 01:16:54ghsetstatus: needs-reproduction -> wont-fix