darcs

Message4328

Author dagit
Recipients beschmi, dagit, tommy
Date 2008-04-25.04:55:20
Issue Issue814 darcs whatsnew -s does too much work
Content
The following commands work on OS X, and cause darcs to read bigtempfile before
telling you that it is to be added.

For other unices, use --bytes= instead of -c, the --darcs-2 to init doesn't
matter, but I wanted to demonstrate that darcs-2 repos do not fix this issue.

time head -c 17179869184 /dev/zero > bigtempfile
darcs init --darcs-2
darcs add bigtempfile
darcs whats -s

You'll notice this takes much longer than it should.  I'm pretty sure this is
because adding the file puts it pending and the summary needs to know if this is
a binary or non-binary patch.  Determining that a file is not binary requires
reading the whole file in smart_diff and diff_files because has_bin calls
is_funky to look at every char in the file checking for characters that are
typical in binary files.
History
Date User Action Args
2008-04-25 04:55:20dagitcreate
2008-04-25 04:55:21dagitlinkissue814 messages
2008-04-25 04:55:21dagitsetmessageid: <1209099321.89.0.40646848705.issue814@darcs.net>
2008-04-25 04:55:23dagitsetrecipients: + dagit, tommy, beschmi