darcs

Message4397

Author kowey
Recipients beschmi, dagit, droundy, jaredj, kowey, tommy, tux_rocker, twb
Date 2008-04-30.10:11:28
Issue Issue538 wish: trackdown --set-scripts-executable
Content
>  Possibly. But the way I made it work for unhashed repositories, I enabled
>  --set-scripts-executable for record. That way, scripts get stored
>  executably in the pristine and will end up as executables in the test
>  working directory. This is, I presume, why the test works if you get
>  --set-scripts-executable.

Ooh, I don't think it would be very nice to change /anything/ about
pristine. Having --set-scripts-executable affect the test-working
directory sounds like a good thing for record and amend-record... just
not through the pristine directory.

>  And of course, if you want the test to work for trackdown, you also want
>  it to work for record.

I see.  Thanks for pointing that out.

>  The only case I can see, in which a file needs to be set executable during
>  the trackdown, is when a patch that removes a script is unapplied. In that
>  case, doesn't darcs eventually call the apply function for a hunk patch
>  that sets the file executable if it starts with '#!' and
>  --set-scripts-executable is given?

Well... we could find out by looking in the source code.  I remember
that Darcs.Patch.Apply does some detection on this.  Another way to
find out is to write a test :-)
History
Date User Action Args
2008-04-30 10:11:28koweycreate
2008-04-30 10:11:29koweylinkissue538 messages
2008-04-30 10:11:29koweysetrecipients: + kowey, droundy, tommy, beschmi, dagit, trentbuck, twb, jaredj, tux_rocker
2008-09-25 06:25:22adminsetrecipients: - trentbuck