darcs

Message4727

Author dagit
Recipients beschmi, dagit, gwern, tommy
Date 2008-05-16.18:20:38
Issue Issue858 Darcs doesn't return a proper exit code on errors
Content
On Fri, May 16, 2008 at 11:01 AM, gwern <bugs@darcs.net> wrote:

>
>
> Oddly, this seems to cause test problems (otherwise I'd record and send):
>
> TESTS FAILED!
>        whatsnew.sh
>        either_dependency.sh
>
> Do these tests depend on Darcs always succeeding, or were some regressions
> introduced when I wasn't looking?

Thanks for the bug report and the research.  There have been discussions in
the past about what darcs means when it returns success or failure:
http://lists.osuosl.org/pipermail/darcs-devel/2006-September/004789.html

The other one I can't find right now, but it was to the effect, what should
darcs return when a pre or post hook fails?  I don't recall what we decided
to do now, but if I recall correctly you can look in Test.lhs and find the
code.

Whatever solution you take here should respect the decisions made in the
past, but I'm not much help beyond that.  I would agree that the behavior
you see in the retry script is wrong.

Jason
Files
File name Uploaded
unnamed dagit, 2008-05-16.18:20:38
History
Date User Action Args
2008-05-16 18:20:38dagitcreate
2008-05-16 18:20:41dagitlinkissue858 messages
2008-05-16 18:20:41dagitsetrecipients: + dagit