1 patch for repository http://darcs.net:

Wed Jul 21 06:37:31 BST 2010  Ganesh Sittampalam <ganesh@earth.li>
  * resolve issue1896: enable witnesses for library

Attachments

• resolve-issue1896_-enable-witnesses-for-library.dpatch
• unnamed

Hi,

Ganesh Sittampalam <bugs@darcs.net> writes:

resolve issue1896: enable witnesses for library
-----------------------------------------------
> hunk ./darcs.cabal 205
>      hs-source-dirs:   src
>      include-dirs:     src
>  
> +    cpp-options:      -DGADT_WITNESSES=1
One thing occurred to me: how are the library users going to get those
CPP macros? I guess gadt.h is not installed by cabal, is it?

I guess the easiest way out is for the library clients to not use those
funny C(...)/FORALL(...) things. We may need to document that, though,
since darcs itself still needs them, so when people look at darcs code
for example usage, they could become quite confused. Maybe a release
note is appropriate, to this effect?

Other than that, ACK.

Yours,
   Petr.

Petr Rockai wrote:
> Hi,
> 
> Ganesh Sittampalam <bugs@darcs.net> writes:
> 
> resolve issue1896: enable witnesses for library
> -----------------------------------------------
>> hunk ./darcs.cabal 205
>>      hs-source-dirs:   src
>>      include-dirs:     src
>> 
>> +    cpp-options:      -DGADT_WITNESSES=1
> One thing occurred to me: how are the library users going to get
> those CPP macros? I guess gadt.h is not installed by cabal, is it? 
> 
> I guess the easiest way out is for the library clients to not use
> those funny C(...)/FORALL(...) things. We may need to document that,
> though, since darcs itself still needs them, so when people look at
> darcs code for example usage, they could become quite confused. Maybe
> a release note is appropriate, to this effect?    

Yeah. I did think about this and came to the same conclusion you did
about not using them, given that our end goal is to be rid of them
anyway. I agree re documentation - and we should perhaps settle on a
naming convention, along the lines that we discussed on IRC some days
back.

Ganesh

=============================================================================== 
Please access the attached hyperlink for an important electronic communications disclaimer: 
http://www.credit-suisse.com/legal/en/disclaimer_email_ib.html 
===============================================================================

This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-e5e246799c38b27303d09692b509a5d5c97dff1e

This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-e5e246799c38b27303d09692b509a5d5c97dff1e