darcs

Patch 1004 windows test fix: replace shell script w... (and 3 more)

Title windows test fix: replace shell script w... (and 3 more)
Superseder Nosy List ganesh
Related Issues
Status accepted Assigned To
Milestone

Created on 2013-01-01.13:29:44 by ganesh, last changed 2013-04-25.19:17:44 by gh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt ganesh, 2013-01-01.13:29:43 text/x-darcs-patch
unnamed ganesh, 2013-01-01.13:29:43
windows-test-fix_-replace-shell-script-with-a-haskell-program.dpatch ganesh, 2013-01-01.13:29:43 application/x-darcs-patch
See mailing list archives for discussion on individual patches.
Messages
msg16516 (view) Author: ganesh Date: 2013-01-01.13:29:43
Getting the encoding tests running on Windows

4 patches for repository darcs-unstable@darcs.net:screened:

Mon Dec 31 22:43:32 GMT 2012  Ganesh Sittampalam <ganesh@earth.li>
  * windows test fix: replace shell script with a Haskell program

Mon Dec 31 22:46:00 GMT 2012  Ganesh Sittampalam <ganesh@earth.li>
  * improve diagnostics when utf8 test fails

Tue Jan  1 12:02:46 GMT 2013  Ganesh Sittampalam <ganesh@earth.li>
  * unsetting DARCS_TEST_PREFS_DIR in utf8 test doesn't seem to be necessary
  
  It was causing problems on Windows because getAppUserDataDirectory
  still returns the normal user directory.
  
  It also means that the repository type choice isn't picked up.

Tue Jan  1 12:22:54 GMT 2013  Ganesh Sittampalam <ganesh@earth.li>
  * We can use chcp to switch encodings on Windows
  This means that the tests that require different encodings can run.
Attachments
msg16774 (view) Author: gh Date: 2013-04-25.19:17:44
The patches seem reasonable and do not break tests under linux. 
Accepting.
History
Date User Action Args
2013-01-01 13:29:44ganeshcreate
2013-01-13 22:11:31ganeshsetstatus: needs-screening -> needs-review
2013-04-25 19:17:44ghsetstatus: needs-review -> accepted
messages: + msg16774