Patch 101: Resolve issue1594: define PREPROCHTML in makefile - Darcs bug tracker

Title	Resolve issue1594: define PREPROCHTML in makefile
Superseder		Nosy List	darcs-users, fx, ganesh, twb
Related Issues	random garbage in HTML version of manual View: 1594
Status	accepted	Assigned To	twb
Milestone

Created on 2009-11-25.18:18:52 by fx, last changed 2011-05-10.17:16:00 by darcswatch. Tracked on DarcsWatch.

Files
File name	Status	Uploaded	Type	Edit	Remove
resolve-issue1594_-define-preprochtml-in-makefile.dpatch		fx, 2009-11-25.18:18:50	text/x-darcs-patch
unnamed		fx, 2009-11-25.18:18:51	text/plain

See mailing list archives for discussion on individual patches.

Messages
msg9496 (view)	Author: fx	Date: 2009-11-25.18:18:51
Mon Nov 23 16:20:06 GMT 2009 Dave Love <fx@gnu.org> * Resolve issue1594: define PREPROCHTML in makefile Attachments resolve-issue1594_-define-preprochtml-in-makefile.dpatch unnamed
msg9544 (view)	Author: ganesh	Date: 2009-12-06.01:52:23
This looks sane to me - Trent, could you just confirm?
msg9551 (view)	Author: twb	Date: 2009-12-07.00:47:14
Ganesh Sittampalam wrote: > This looks sane to me - Trent, could you just confirm? Sorry; I meant to look at this when it first came in. The old code used to call src/preproc with/without --html. That argument got lost when Petr moved the code into the Darcs binary (to appease cabal). I'm assuming this just re-adds the --html argument in the makefile, and that the corresponding --html argument is still handled by whatever file src/preproc.hs became. I'll try to check those assumptions sometime in the next few days.
msg9553 (view)	Author: fx	Date: 2009-12-07.12:51:03
"Trent W. Buck" <bugs@darcs.net> writes: > That argument got lost when Petr moved the code into the Darcs binary > (to appease cabal). I'm assuming this just re-adds the --html > argument in the makefile, and that the corresponding --html argument > is still handled by whatever file src/preproc.hs became. Yes, though I can't remember the details. I did test it, in case that's not clear.
msg9567 (view)	Author: darcswatch	Date: 2009-12-09.02:25:43
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-3446f276fd6476abee1ea575230b381ca293087c
msg14043 (view)	Author: darcswatch	Date: 2011-05-10.17:16:00
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-3446f276fd6476abee1ea575230b381ca293087c

History
Date	User	Action	Args
2009-11-25 18:18:52	fx	create
2009-11-25 18:23:36	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html
2009-12-05 23:06:26	ganesh	set	issues: + random garbage in HTML version of manual
2009-12-06 01:52:23	ganesh	set	nosy: + twb, ganesh messages: + msg9544 assignedto: twb
2009-12-07 00:47:15	twb	set	messages: + msg9551
2009-12-07 12:51:04	fx	set	messages: + msg9553
2009-12-09 02:25:44	darcswatch	set	status: needs-review -> accepted messages: + msg9567
2011-05-10 17:16:00	darcswatch	set	messages: + msg14043