Patch 1012: rename init --hashed into init --darcs-1 - Darcs bug tracker

Title	rename init --hashed into init --darcs-1
Superseder		Nosy List	ganesh, gh
Related Issues
Status	accepted	Assigned To	ganesh
Milestone

Created on 2013-01-13.19:09:07 by gh, last changed 2013-02-17.13:40:15 by gh.

Files
File name	Status	Uploaded	Type	Edit	Remove
display-error-message-when-using-init-__hashed.dpatch		gh, 2013-02-17.11:25:10	application/x-darcs-patch
fix-tests-after-changing-__hashed-into-__darcs_1.dpatch		gh, 2013-01-14.17:34:54	application/x-darcs-patch
patch-preview.txt		gh, 2013-01-13.19:09:07	text/x-darcs-patch
patch-preview.txt		gh, 2013-01-14.17:34:54	text/x-darcs-patch
patch-preview.txt		gh, 2013-02-17.11:25:10	text/x-darcs-patch
patch-preview.txt		gh, 2013-02-17.13:34:50	text/x-darcs-patch
rename-init-__hashed-into-init-__darcs_1.dpatch		gh, 2013-01-13.19:09:07	application/x-darcs-patch
rm-testing-old_fashioned-repo-with-checkpoint_-since-what-we-test-already-fails-because-it_s-of.dpatch		gh, 2013-02-17.13:34:50	application/x-darcs-patch
unnamed		gh, 2013-01-13.19:09:07
unnamed		gh, 2013-01-14.17:34:54
unnamed		gh, 2013-02-17.11:25:10
unnamed		gh, 2013-02-17.13:34:50

See mailing list archives for discussion on individual patches.

Messages
msg16534 (view)	Author: gh	Date: 2013-01-13.19:09:07
All repositories created by init are hashed (since a couple of years), moreover I suspect very few people use the --hashed flag, and even less have the need to automatize this by scripting. Hence I believe renaming --hased to --darcs-1 has a very minor cost, and yields more consistency to the UI. 1 patch for repository http://darcs.net: Sun Jan 13 01:04:49 ART 2013 Guillaume Hoffmann <guillaumh@gmail.com> * rename init --hashed into init --darcs-1 Attachments patch-preview.txt rename-init-__hashed-into-init-__darcs_1.dpatch unnamed
msg16535 (view)	Author: ganesh	Date: 2013-01-13.22:30:17
Did you check the tests? Some of them use --hashed
msg16536 (view)	Author: gh	Date: 2013-01-14.17:34:54
2 patches for repository http://darcs.net: Mon Jan 14 14:18:10 ART 2013 Guillaume Hoffmann <guillaumh@gmail.com> * fix tests after changing --hashed into --darcs-1 Mon Jan 14 14:30:28 ART 2013 Guillaume Hoffmann <guillaumh@gmail.com> * darcs-test UI: print Darcs1 in place of Hashed Attachments fix-tests-after-changing-__hashed-into-__darcs_1.dpatch patch-preview.txt unnamed
msg16545 (view)	Author: ganesh	Date: 2013-01-20.22:44:44
Shouldn't we do something to re-direct people who are used to the old flag? (either tell them or treat them as synonyms)
msg16582 (view)	Author: gh	Date: 2013-02-14.17:46:23
I don't feel like this is an option people really use (beyond debugging), to justify complexifying the code. At the very least the wiki should be up to date with both versions of the flag.
msg16678 (view)	Author: gh	Date: 2013-02-17.11:25:10
1 patch for repository http://darcs.net: Sun Feb 17 12:20:51 CET 2013 Guillaume Hoffmann <guillaumh@gmail.com> * display error message when using init --hashed Attachments display-error-message-when-using-init-__hashed.dpatch patch-preview.txt unnamed
msg16679 (view)	Author: ganesh	Date: 2013-02-17.11:29:09
looks fine, thanks for adding the error
msg16681 (view)	Author: gh	Date: 2013-02-17.13:34:50
Two followup patches that make the testsuite work with the flag darcs-1 in .darcs/defaults. Will self-accept since it modifies only the testsuite. 2 patches for repository http://darcs.net: Sun Feb 17 13:54:40 CET 2013 Guillaume Hoffmann <guillaumh@gmail.com> * rm testing old-fashioned repo with checkpoint, since what we test already fails because it's OF Sun Feb 17 14:22:15 CET 2013 Guillaume Hoffmann <guillaumh@gmail.com> * tests: check if darcs-1 in .darcs/defaults instead of hashed, and no longer check OF Attachments patch-preview.txt rm-testing-old_fashioned-repo-with-checkpoint_-since-what-we-test-already-fails-because-it_s-of.dpatch unnamed

History
Date	User	Action	Args
2013-01-13 19:09:07	gh	create
2013-01-13 22:11:51	ganesh	set	status: needs-screening -> needs-review
2013-01-13 22:30:18	ganesh	set	messages: + msg16535
2013-01-14 17:34:55	gh	set	files: + patch-preview.txt, fix-tests-after-changing-__hashed-into-__darcs_1.dpatch, unnamed messages: + msg16536
2013-01-20 22:44:44	ganesh	set	status: needs-review -> review-in-progress assignedto: ganesh messages: + msg16545 nosy: + ganesh
2013-02-14 17:46:24	gh	set	messages: + msg16582
2013-02-17 11:25:11	gh	set	files: + patch-preview.txt, display-error-message-when-using-init-__hashed.dpatch, unnamed messages: + msg16678
2013-02-17 11:29:09	ganesh	set	status: review-in-progress -> accepted-pending-tests messages: + msg16679
2013-02-17 13:34:51	gh	set	files: + patch-preview.txt, rm-testing-old_fashioned-repo-with-checkpoint_-since-what-we-test-already-fails-because-it_s-of.dpatch, unnamed messages: + msg16681
2013-02-17 13:40:15	gh	set	status: accepted-pending-tests -> accepted