darcs

Patch 1018 added tests for issue 2270

Title added tests for issue 2270
Superseder Nosy List sebfisch
Related Issues
Status accepted Assigned To
Milestone

Created on 2013-02-10.14:54:34 by sebfisch, last changed 2013-02-16.15:59:31 by gh.

Files
File name Status Uploaded Type Edit Remove
added-tests-for-issue-2270.dpatch sebfisch, 2013-02-10.14:54:33 application/x-darcs-patch
added-tests-for-issue-2270.dpatch ganesh, 2013-02-14.19:23:28 application/x-darcs-patch
patch-preview.txt sebfisch, 2013-02-10.14:54:33 text/x-darcs-patch
patch-preview.txt ganesh, 2013-02-14.19:23:27 text/x-darcs-patch
unnamed sebfisch, 2013-02-10.14:54:33
unnamed ganesh, 2013-02-14.19:23:28
See mailing list archives for discussion on individual patches.
Messages
msg16570 (view) Author: sebfisch Date: 2013-02-10.14:54:33
1 patch for repository /home/sebfisch/Code/Haskell/darcs/screened:

Sun Feb 10 15:23:57 CET 2013  Sebastian Fischer <mail@sebfisch.de>
  * added tests for issue 2270
  
  I have added a test script for issue 2270: darcs change should only
  show changes to relevant files.
    
  Currently, `darcs changes --interactive --only-to-files` shows changes
  to files not asked for.
    
  To avoid regressions when fixing this bug, I have also added tests for
  `--interactive`, `--verbose`, and `--verbose --only-to-files` as well
  as tests to check the handling of moved files.
Attachments
msg16583 (view) Author: ganesh Date: 2013-02-14.19:23:28
Just adding a windows fix

2 patches for repository darcs-unstable@darcs.net:screened:

Sun Feb 10 14:23:57 GMT 2013  Sebastian Fischer <mail@sebfisch.de>
  * added tests for issue 2270
  
  I have added a test script for issue 2270: darcs change should only
  show changes to relevant files.
    
  Currently, `darcs changes --interactive --only-to-files` shows changes
  to files not asked for.
    
  To avoid regressions when fixing this bug, I have also added tests for
  `--interactive`, `--verbose`, and `--verbose --only-to-files` as well
  as tests to check the handling of moved files.
  
  

Thu Feb 14 19:13:36 GMT 2013  Ganesh Sittampalam <ganesh@earth.li>
  * Windows fix for issue2270 test
Attachments
msg16588 (view) Author: ganesh Date: 2013-02-15.10:40:33
Great, thanks.

A few comments - as you'll see from my followup, using 'yes' isn't generally 
available on mingw/msys where the tests get run on Windows.

I've also sent a followup in patch1021 that gets rid of some trailing whitespace and 
also adds a few more tests of the interaction with file moves.
History
Date User Action Args
2013-02-10 14:54:34sebfischcreate
2013-02-14 19:23:28ganeshsetfiles: + patch-preview.txt, added-tests-for-issue-2270.dpatch, unnamed
messages: + msg16583
2013-02-14 22:31:13ganeshsetstatus: needs-screening -> needs-review
2013-02-15 10:40:33ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg16588
2013-02-16 15:59:31ghsetstatus: accepted-pending-tests -> accepted