darcs

Patch 1019 resolve issue2270: fixed darcs changes -i --only-to-files

Title resolve issue2270: fixed darcs changes -i --only-to-files
Superseder Nosy List sebfisch
Related Issues
Status accepted Assigned To
Milestone

Created on 2013-02-10.15:17:44 by sebfisch, last changed 2013-02-16.15:59:22 by gh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt sebfisch, 2013-02-10.15:17:44 text/x-darcs-patch
resolve-issue2270_-fixed-darcs-changes-_i-__only_to_files.dpatch sebfisch, 2013-02-10.15:17:44 application/x-darcs-patch
unnamed sebfisch, 2013-02-10.15:17:44
See mailing list archives for discussion on individual patches.
Messages
msg16571 (view) Author: sebfisch Date: 2013-02-10.15:17:44
1 patch for repository /home/sebfisch/Code/Haskell/darcs/screened:

I have moved the patch filtering code for the flag `--only-to-files`
from the `changelog` function to the `getChangesInfo` function in the
module `Darcs.UI.Commands.Changes`. As a consequence, `darcs changes
--interactive --only-to-files` now shows the same changes as `darcs
changes --verbose --only-to-files`, fixing issue 2270.

All functional tests still pass and there are no new failures for the
unit tests. The newly added functional test for issue 2270 now also
passes.

Sun Feb 10 15:32:44 CET 2013  Sebastian Fischer <mail@sebfisch.de>
  * resolve issue2270: fixed darcs changes -i --only-to-files
  
  `darcs changes --interactive --only-to-files` now only shows changes
  to relevant files.
  
  The options `--interactive` and `--verbose` now use the same filtering
  code in presence of `--only-to-files`, so interactively shown changes
  are the same as verbosely shown changes: with `--only-to-files` only
  changes to the listed files are shown, without this option all changes
  to files recorded together with listed files are shown.
Attachments
msg16589 (view) Author: ganesh Date: 2013-02-15.10:42:33
Code changes look fine, thanks (I fixed a single trailing whitespace in 
patch1021).
History
Date User Action Args
2013-02-10 15:17:44sebfischcreate
2013-02-14 22:31:17ganeshsetstatus: needs-screening -> needs-review
2013-02-15 10:42:33ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg16589
2013-02-16 15:59:22ghsetstatus: accepted-pending-tests -> accepted