This patch makes that DARCS_CONNECTION_TIMEOUT is taken into account.
Noticeably, in cases like the following (non-responding server):

    export DARCS_CONNECTION_TIMEOUT=1 && darcs changes --repo=http://10.1.2.3/

Also, it seems that the correct parameter to pass to libcurl is
CURLOPT_CONNECTTIMEOUT, which limit the connection time to a server.
CURLOPT_TIMEOUT (used up to now) is a timeout on any connection:
for instance transferring a big patch can be interrupted by such limit.

So this patch uses CURLOPT_CONNECTTIMEOUT instead of CURLOPT_TIMEOUT.

1 patch for repository http://darcs.net:

Fri Feb 22 00:43:25 CET 2013  Guillaume Hoffmann <guillaumh@gmail.com>
  * correctly set curl connection timeout

Attachments

• correctly-set-curl-connection-timeout.dpatch
• patch-preview.txt
• unnamed

An extra patch so that we get the debug message that DARCS_CONNECTION_TIMEOUT
is not a number earlier (even before we can actually download a remote file).

I wonder if this warning would occur earlier in the code, at the haskell level?
Is it slow to call getEnv(ironment)?

Also, another patch that sets this timeout to 1 second un the test
issue1599-automatically-expire-unused-caches.sh .

3 patches for repository http://darcs.net:

Thu Feb 21 23:37:32 CET 2013  Guillaume Hoffmann <guillaumh@gmail.com>
  * set timeout to 1 second in expire-unused-caches test

Fri Feb 22 00:43:25 CET 2013  Guillaume Hoffmann <guillaumh@gmail.com>
  * correctly set curl connection timeout

Fri Feb 22 11:07:21 CET 2013  Guillaume Hoffmann <guillaumh@gmail.com>
  * warn earlier when DARCS_CONNECTION_TIMEOUT is not a number

Attachments

• patch-preview.txt
• set-timeout-to-1-second-in-expire_unused_caches-test.dpatch
• unnamed

Without conflicts.

3 patches for repository http://darcs.net:

Fri Feb 22 00:43:25 CET 2013  Guillaume Hoffmann <guillaumh@gmail.com>
  * correctly set curl connection timeout

Fri Feb 22 11:07:21 CET 2013  Guillaume Hoffmann <guillaumh@gmail.com>
  * warn earlier when DARCS_CONNECTION_TIMEOUT is not a number

Fri Feb 22 11:16:34 CET 2013  Guillaume Hoffmann <guillaumh@gmail.com>
  * set timeout to 1 second in expire-unused-caches test

Attachments

• correctly-set-curl-connection-timeout.dpatch
• patch-preview.txt
• unnamed

Self-accepting.