Patch 1058: Increase efficiency of patch index update. - Darcs bug tracker

Title	Increase efficiency of patch index update.
Superseder		Nosy List	bsrkaditya
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2013-02-28.15:25:22 by bsrkaditya, last changed 2013-05-14.15:26:02 by darcswatch. Tracked on DarcsWatch.

Files
File name	Status	Uploaded	Type	Edit	Remove
increase-efficiency-of-patch-index-update-by-more-efficient-extraction.dpatch		bsrkaditya, 2013-02-28.15:25:21	application/octet-stream

See mailing list archives for discussion on individual patches.

Messages
msg16728 (view)	Author: bsrkaditya	Date: 2013-02-28.15:25:21
This patch increases the efficiency of extraction of the new patches in patch index update. I have tested its effectiveness with gh's benchmark. The new values: ==> timings-proto/PI_add_disable-patch-index <== 0.28 ==> timings-proto/PI_add_patch-index <== 0.31 ==> timings-proto/PI_amend_disable-patch-index <== 21.21 ==> timings-proto/PI_amend_patch-index <== 25.43 ==> timings-proto/PI_obliterate_disable-patch-index <== 18.80 ==> timings-proto/PI_obliterate_patch-index <== 21.95 ==> timings-proto/PI_record_disable-patch-index <== 115.16 ==> timings-proto/PI_record_patch-index <== 144.02 The old values: ==> timings/PI_add_disable-patch-index <== 0.28 ==> timings/PI_add_patch-index <== 0.31 ==> timings/PI_amend_disable-patch-index <== 21.45 ==> timings/PI_amend_patch-index <== 27.25 ==> timings/PI_obliterate_disable-patch-index <== 18.50 ==> timings/PI_obliterate_patch-index <== 22.25 ==> timings/PI_record_disable-patch-index <== 117.02 ==> timings/PI_record_patch-index <== 150.38 Clearly, I have not been able to reproduce the large pi update inefficiency. So I suspect this patch will not help much. :-) Nonetheless, It is still a (small) improvement. Attachments increase-efficiency-of-patch-index-update-by-more-efficient-extraction.dpatch
msg16787 (view)	Author: gh	Date: 2013-04-29.23:47:19
Compiles and does not break any test, but someone that understands better the patch index should review it.
msg16789 (view)	Author: darcswatch	Date: 2013-04-30.00:06:10
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/screened. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_screened.html#bundle-502b2167d233d74d283671a2000800925e96306c
msg16811 (view)	Author: gh	Date: 2013-05-14.15:12:24
OK the change looks fine to me although I'm not the most confident to judge.
msg16812 (view)	Author: darcswatch	Date: 2013-05-14.15:26:02
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-502b2167d233d74d283671a2000800925e96306c

History
Date	User	Action	Args
2013-02-28 15:25:22	bsrkaditya	create
2013-02-28 15:26:34	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-502b2167d233d74d283671a2000800925e96306c
2013-04-29 23:47:19	gh	set	status: needs-screening -> needs-review messages: + msg16787
2013-04-30 00:06:10	darcswatch	set	messages: + msg16789
2013-05-14 15:12:24	gh	set	status: needs-review -> accepted messages: + msg16811
2013-05-14 15:26:02	darcswatch	set	messages: + msg16812