Patch 1064: resolve issue2311: posthook for 'get' should run in cr... - Darcs bug tracker

Title	resolve issue2311: posthook for 'get' should run in cr...
Superseder		Nosy List	sebfisch
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2013-03-08.13:33:37 by sebfisch, last changed 2013-06-08.20:22:32 by gh.

Files
File name	Status	Uploaded	Type	Edit	Remove
patch-preview.txt		sebfisch, 2013-03-08.13:33:37	text/x-darcs-patch
resolve-issue2311_-posthook-for-_get_-should-run-in-created-repo.dpatch		sebfisch, 2013-03-08.13:33:37	application/x-darcs-patch
unnamed		sebfisch, 2013-03-08.13:33:37

See mailing list archives for discussion on individual patches.

Messages
msg16748 (view)	Author: sebfisch	Date: 2013-03-08.13:33:37
1 patch for repository /home/sebfisch/Code/Haskell/darcs/screened: Fri Mar 8 14:07:54 CET 2013 Sebastian Fischer <mail@sebfisch.de> * resolve issue2311: posthook for 'get' should run in created repo I have added a function `getPosthookDir` to `Darcs.UI.RunCommand` that computes a working dir for posthooks based on the current directory based on the name of the command and the directory in which the command is run. For most commands the previous behavior is retained. For the `get` command, the newly created repository is used as working dir for posthooks. To avoid code duplication, I have exported `makeRepoName` from `Darcs.UI.Commands.Get` and used it in the function `getPosthookDir` to compute the name that darcs will use for the newly created repository. The newly added tests for issue2311 (which were previously failing) now pass. Attachments patch-preview.txt resolve-issue2311_-posthook-for-_get_-should-run-in-created-repo.dpatch unnamed
msg16836 (view)	Author: gh	Date: 2013-06-08.20:22:32
Looks good to me.

History
Date	User	Action	Args
2013-03-08 13:33:37	sebfisch	create
2013-06-08 20:22:32	gh	set	status: needs-screening -> accepted messages: + msg16836