darcs

Patch 1065 Added tests for issue2312: posthooks for 'record' and ...

Title Added tests for issue2312: posthooks for 'record' and ...
Superseder Nosy List sebfisch
Related Issues
Status accepted Assigned To
Milestone

Created on 2013-03-09.20:34:10 by sebfisch, last changed 2013-06-08.22:20:58 by gh.

Files
File name Status Uploaded Type Edit Remove
added-tests-for-issue2312_-posthooks-for-_record_-and-_amend_record_-should-receive-darcs_patches.dpatch sebfisch, 2013-03-09.20:34:10 application/x-darcs-patch
added-tests-for-issue2312_-posthooks-for-_record_-and-_amend_record_-should-receive-darcs_patches.dpatch ganesh, 2013-04-05.21:23:38 application/x-darcs-patch
patch-preview.txt sebfisch, 2013-03-09.20:34:10 text/x-darcs-patch
patch-preview.txt ganesh, 2013-04-05.21:23:38 text/x-darcs-patch
unnamed sebfisch, 2013-03-09.20:34:10
unnamed ganesh, 2013-04-05.21:23:38
See mailing list archives for discussion on individual patches.
Messages
msg16749 (view) Author: sebfisch Date: 2013-03-09.20:34:10
1 patch for repository /home/sebfisch/Code/Haskell/darcs/screened:

Sat Mar  9 21:19:00 CET 2013  Sebastian Fischer <mail@sebfisch.de>
  * Added tests for issue2312: posthooks for 'record' and 'amend-record' should receive DARCS_PATCHES
  
  I have added tests to ensure that posthooks for 'record' and
  'amend-record' receive correct patch descriptions in the environment
  variable DARCS_PATCHES.


I did not run the tests on Windows. From the source code I gather that
environment variables are not set on Windows, so I think it is
necessary to disable these tests on Windows. Is this correct? How can
this be done?
Attachments
msg16762 (view) Author: ganesh Date: 2013-04-05.21:23:38
Adding a tweak to avoid a failure on Windows

2 patches for repository http://darcs.net/screened:

Sat Mar  9 20:19:00 GMT 2013  Sebastian Fischer <mail@sebfisch.de>
  * Added tests for issue2312: posthooks for 'record' and 'amend-record' should receive DARCS_PATCHES
  
  I have added tests to ensure that posthooks for 'record' and
  'amend-record' receive correct patch descriptions in the environment
  variable DARCS_PATCHES.
  

Fri Apr  5 22:09:50 BST 2013  Ganesh Sittampalam <ganesh@earth.li>
  * fix test for Windows
Attachments
msg16763 (view) Author: ganesh Date: 2013-04-05.21:25:33
Apologies for the delay in looking at this.

I've dealt with the Windows problem - it just needs an abort_windows at 
the top, but I've also made sure the test will work if we ever sort out 
the environment variables on Windows.

We use Haskell programs instead of shell scripts when we need to 
simulate an external program, because Windows doesn't execute 
subprograms through the shell.
History
Date User Action Args
2013-03-09 20:34:11sebfischcreate
2013-04-05 21:23:39ganeshsetfiles: + patch-preview.txt, added-tests-for-issue2312_-posthooks-for-_record_-and-_amend_record_-should-receive-darcs_patches.dpatch, unnamed
messages: + msg16762
2013-04-05 21:25:33ganeshsetstatus: needs-screening -> accepted-pending-tests
messages: + msg16763
2013-06-08 22:20:58ghsetstatus: accepted-pending-tests -> accepted