darcs

Patch 1066 resolve issue2312: posthooks for 'record' and 'amend-r...

Title resolve issue2312: posthooks for 'record' and 'amend-r...
Superseder resolve issue2312: posthooks for 'record... (and 1 more)
View: 1067
Nosy List sebfisch
Related Issues
Status obsoleted Assigned To
Milestone

Created on 2013-03-09.20:36:32 by sebfisch, last changed 2013-06-08.22:11:47 by gh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt sebfisch, 2013-03-09.20:36:32 text/x-darcs-patch
resolve-issue2312_-posthooks-for-_record_-and-_amend_record_-should-receive-darcs_patches.dpatch sebfisch, 2013-03-09.20:36:32 application/x-darcs-patch
unnamed sebfisch, 2013-03-09.20:36:32
See mailing list archives for discussion on individual patches.
Messages
msg16750 (view) Author: sebfisch Date: 2013-03-09.20:36:32
1 patch for repository /home/sebfisch/Code/Haskell/darcs/screened:

Sat Mar  9 21:22:19 CET 2013  Sebastian Fischer <mail@sebfisch.de>
  * resolve issue2312: posthooks for 'record' and 'amend-record' should receive DARCS_PATCHES
  
  I have extended the 'record' and 'amend-record' commands to supply the
  environment variable DARCS_PATCHES to posthooks.
  
  The contents of DARCS_PATCHES is computed and provided by a new
  function `Darcs.UI.Commands.Util.setChangesEnvAfter` that is used to
  wrap the 'record' and 'amend-record' commands.
  
  This function reads the repository before and after the executed
  command. It uses the existing function
  `Darcs.Patch.Depends.findCommonWithThem` to compute the changes made
  by the command and `Darcs.UI.Commands.setEnvDarcsPatches` to provide
  them to posthooks.

I compute the changes using `readRepo` twice - once before and once
after a 'record' or 'amend-record'. Is this ok regarding efficiency?
Is there a better way to retrieve the necessary descriptions of the
changes made by each command?
Attachments
History
Date User Action Args
2013-03-09 20:36:32sebfischcreate
2013-06-08 22:11:47ghsetstatus: needs-screening -> obsoleted
superseder: + resolve issue2312: posthooks for 'record... (and 1 more)