darcs

Patch 1073 resolv issue2321: remove "Do you want to add a long co...

Title resolv issue2321: remove "Do you want to add a long co...
Superseder Nosy List ganesh, jlneder
Related Issues
Status accepted Assigned To
Milestone

Created on 2013-06-04.04:50:29 by jlneder, last changed 2016-01-12.07:02:12 by ganesh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt jlneder, 2013-06-04.04:50:28 text/x-darcs-patch
patch-preview.txt jlneder, 2013-06-05.03:57:51 text/x-darcs-patch
patch-preview.txt jlneder, 2013-06-05.21:43:04 text/x-darcs-patch
patch-preview.txt jlneder, 2013-06-06.23:14:15 text/x-darcs-patch
resolv-issue2321_-remove-_do-you-want-to-add-a-long-comment__-prompt.dpatch jlneder, 2013-06-04.04:50:28 application/x-darcs-patch
resolve-issue2321_-when-no-patch-name-given_-directly-invoke-text-editor.dpatch jlneder, 2013-06-05.03:57:51 application/x-darcs-patch
resolve-issue2321_-when-no-patch-name-given_-directly-invoke-text-editor.dpatch jlneder, 2013-06-05.21:43:04 application/x-darcs-patch
resolve-issue2321_-when-no-patch-name-given_-directly-invoke-text-editor.dpatch jlneder, 2013-06-06.23:14:16 application/x-darcs-patch
unnamed jlneder, 2013-06-04.04:50:28
unnamed jlneder, 2013-06-05.03:57:51
unnamed jlneder, 2013-06-05.21:43:04
unnamed jlneder, 2013-06-06.23:14:16
See mailing list archives for discussion on individual patches.
Messages
msg16825 (view) Author: jlneder Date: 2013-06-04.04:50:28
1 patch for repository http://darcs.net/screened:

Tue Jun  4 00:43:48 ART 2013  Jose Luis Neder <jlneder@gmail.com>
  * resolv issue2321: remove "Do you want to add a long comment?" prompt

It's strange that nobody mention you could configure this with "record edit-long-comment" in ~/.darcs/defaults.
Anyhow, this patch changes the behavior without the need of this configuration. Besides, it can be reverted only adding "record prompt-long-comment".
Warning: It changes the behaviour in "tag" and "amend-record" too. But it can be reverted in the same way that with "record".
Attachments
msg16827 (view) Author: gh Date: 2013-06-04.15:05:37
I've tried the new behaviour, and I realised that you implemented my 
initial proposal in the discussion of issue2321, whereas in fact the 
discussion on this issue evolved towards the solution of directly 
launching the text editor to ask for patch name + long comment ( 
http://bugs.darcs.net/msg16808 ). Right now I'm renaming the issue to 
reflect this final proposal. Sorry about the confusion.

Also can you make the patch name start with "resolve issue2321" (with 
e)? This way our scripts can detect that the issue is closed when the 
patch gets accepted.
msg16828 (view) Author: jlneder Date: 2013-06-05.03:57:51
1 patch for repository http://darcs.net/screened:

Wed Jun  5 00:46:35 ART 2013  Jose Luis Neder <jlneder@gmail.com>
  * resolve issue2321: when no patch name given, directly invoke text editor
I dont see the missing "e", sorry. There it is the new patch.
Attachments
msg16829 (view) Author: jlneder Date: 2013-06-05.21:43:04
1 patch for repository http://darcs.net/screened:

Wed Jun  5 18:35:53 ART 2013  Jose Luis Neder <jlneder@gmail.com>
  * resolve issue2321: when no patch name given, directly invoke text editor
I think it's ok now.
Attachments
msg16830 (view) Author: gh Date: 2013-06-06.01:19:37
So now with this patch:

* `darcs rec -m patchname` is like before (does not prompt anything)

* `darcs rec` and `darcs rec --edit-long-comment` have the same behaviour 
(directly launch the editor)
* `darcs rec -m patchname --edit-long-comment` also launches the editor (with 
patchname in the first line)

* `darcs rec --skip-long-comment` prompts for the patch name without 
launching the editor
* `darcs rec -m patchname` and `darcs rec -m patchname --skip-long-comment` 
have the same behaviour (as before)

* `darcs rec --prompt-long-comment` directly launches the editor (instead of 
asking "do you want to add a long comment?), I'm not sure it's good or not.
* `darcs rec -m patchname --prompt-long-comment` works as before (asks if 
user want to enter long comment)


The only weird case seems to be `rec --prompt-long-comment` since it does not 
prompt anything. 

I think you should fix the `darcs rec --prompt-long-comment` case so that 
users who want the old behaviour just add "record prompt-long-comment" to 
their defaults.
msg16831 (view) Author: jlneder Date: 2013-06-06.23:14:16
1 patch for repository http://darcs.net/screened:

Thu Jun  6 20:06:01 ART 2013  Jose Luis Neder <jlneder@gmail.com>
  * resolve issue2321: when no patch name given, directly invoke text editor
I fixed the case `darcs rec --prompt-long-comment`.
I added the question 'What is the path name?" too because it seems to me that without this the next question "Do you want to add a long comment?" is irrelevant. You don't want to make patch without any comment nor name, do you? I think it's better this way.
Attachments
msg16832 (view) Author: gh Date: 2013-06-07.23:53:30
Yes I agree it makes sense.

I'm screening it and will wait a couple of days before accepting it in 
case someone else has comments.
msg16847 (view) Author: gh Date: 2013-06-10.02:37:28
I'm pushing it to reviewed.
msg17003 (view) Author: ganesh Date: 2013-08-26.00:47:00
This patch turns out to break the utf8 test on both Windows and Linux. 
On Linux (Debian) it somehow causes nano to hang eating CPU - I've seen 
this on two machines so far.

Unfortunately the UTF8 test is skipped by default. On Debian installing 
the locales-all package is the simplest way to get it to run.
msg17093 (view) Author: ganesh Date: 2013-11-26.23:26:01
The test also fails outright on Windows.
msg18896 (view) Author: gh Date: 2016-01-11.15:48:42
I see that the utf8-display.sh test is passing with the current
darcs-screened repository, under Linux.  Can you try under Windows?
msg18897 (view) Author: ganesh Date: 2016-01-12.07:02:11
The utf8.sh test has now been renamed to latin9-input.sh. It does seem 
fine on Windows and Linux, so I guess someone (maybe me) already fixed 
the issue.
History
Date User Action Args
2013-06-04 04:50:29jlnedercreate
2013-06-04 15:05:38ghsetmessages: + msg16827
2013-06-05 03:57:52jlnedersetfiles: + patch-preview.txt, resolve-issue2321_-when-no-patch-name-given_-directly-invoke-text-editor.dpatch, unnamed
messages: + msg16828
2013-06-05 21:43:05jlnedersetfiles: + patch-preview.txt, resolve-issue2321_-when-no-patch-name-given_-directly-invoke-text-editor.dpatch, unnamed
messages: + msg16829
2013-06-06 01:19:38ghsetmessages: + msg16830
2013-06-06 23:14:16jlnedersetfiles: + patch-preview.txt, resolve-issue2321_-when-no-patch-name-given_-directly-invoke-text-editor.dpatch, unnamed
messages: + msg16831
2013-06-07 23:53:31ghsetstatus: needs-screening -> needs-review
messages: + msg16832
2013-06-10 02:37:28ghsetstatus: needs-review -> accepted
messages: + msg16847
2013-08-26 00:47:00ganeshsetnosy: + ganesh
messages: + msg17003
2013-11-26 23:26:02ganeshsetstatus: accepted -> followup-requested
assignedto: jlneder
messages: + msg17093
2016-01-11 15:48:43ghsetmessages: + msg18896
2016-01-12 07:02:12ganeshsetstatus: followup-requested -> accepted
assignedto: jlneder ->
messages: + msg18897