1 patch for repository http://darcs.net/screened:

Sat Jun 15 02:02:56 ART 2013  Jose Luis Neder <jlneder@gmail.com>
  * resolve issue2320: save prompted author name in ~/.darcs/author instead of ./_darcs/prefs/author
  It seems unclear to me what to do when "~" isn't found. Perhaps it should
  fail but i'm not sure what to do.

Attachments

• patch-preview.txt
• resolve-issue2320_-save-prompted-author-name-in-___darcs_author-instead-of-___darcs_prefs_author.dpatch
• unnamed

Your patch makes sense, I have comments about some changes:

-import Control.Applicative( (<$>) )
+import Control.Applicative ( (<$>) )

which you can remove from the patch using "darcs amend --unrecord". And:

hunk ./src/Darcs/UI/Arguments.hs 946
-          writeLocaleFile (darcsdir ++ "/prefs/author") $
+          prefsdir <- globalPrefsDir
+          writeLocaleFile (fromMaybe "~" prefsdir </> "author") $

in which the use 'fromMaybe "~"' is incorrect since it would create the
file "~/author" in the case when globalPrefsDir returns Nothing.

As for what to do when globalPrefsDir returns Nothing (an unlikely
situation but we should foresee it in the code), I'm thinking of two
alternatives:

a) make darcs fail
b) make darcs save author in _darcs/prefs/author (as before).

I think b) would be the best, with a warning message when it happens
(look for WARNING: in the source code).

1 patch for repository http://darcs.net/screened:

Sat Jun 15 17:21:39 ART 2013  Jose Luis Neder <jlneder@gmail.com>
  * resolve issue2320: save prompted author name in ~/.darcs/author instead of ./_darcs/prefs/author
  I made the changes you suggested. I think is much better now. Thanks.

Attachments

• patch-preview.txt
• resolve-issue2320_-save-prompted-author-name-in-___darcs_author-instead-of-___darcs_prefs_author.dpatch
• unnamed

Good. Last suggestions:

+                    putStrLn $ "WARNING: $HOME environment variable not
set."

Under Windows this message would not make sense. Following the
vocabulary used in the comment of the globalPrefsDir function, this
would rather be: "WARNING: Global preference directory could not be
found." Also the $ is unnecessary.

And there is a double "if" there:

+ "string and write it to `" ++ globalPrefsDirDoc ++ "author`.  Note
that if if you have more",

1 patch for repository http://darcs.net/screened:

Sat Jun 15 23:39:04 ART 2013  Jose Luis Neder <jlneder@gmail.com>
  * resolve issue2320: save prompted author name in ~/.darcs/author instead of ./_darcs/prefs/author
  fixed.

Attachments

• patch-preview.txt
• resolve-issue2320_-save-prompted-author-name-in-___darcs_author-instead-of-___darcs_prefs_author.dpatch
• unnamed

Good to go. I'm sending a patch that fixes a weird repetition in the
help string written to ~/.darcs/author.

Will self-accept as trivial patch (http://darcs.net/Development/PatchReview).

1 patch for repository http://darcs.net:

Sun Jun 16 13:41:12 ART 2013  Guillaume Hoffmann <guillaumh@gmail.com>
  * remove word repetition in fileHelpAuthor string

Attachments

• patch-preview.txt
• remove-word-repetition-in-filehelpauthor-string.dpatch
• unnamed