darcs

Patch 1080 merge Darcs.Util.IO into Darcs.Util.File (and 1 more)

Title merge Darcs.Util.IO into Darcs.Util.File (and 1 more)
Superseder Nosy List gh
Related Issues
Status accepted Assigned To
Milestone

Created on 2013-07-18.12:56:57 by gh, last changed 2013-07-20.10:59:32 by gh.

Files
File name Status Uploaded Type Edit Remove
merge-darcs_util_io-into-darcs_util_file.dpatch gh, 2013-07-18.12:56:57 application/x-darcs-patch
merge-darcs_util_io-into-darcs_util_file.dpatch gh, 2013-07-18.14:19:59 application/x-darcs-patch
merge-darcs_util_io-into-darcs_util_file.dpatch gh, 2013-07-19.10:10:19 application/x-darcs-patch
merge-darcs_util_io-into-darcs_util_file.dpatch gh, 2013-07-19.10:26:32 application/x-darcs-patch
patch-preview.txt gh, 2013-07-18.12:56:57 text/x-darcs-patch
patch-preview.txt gh, 2013-07-18.14:19:59 text/x-darcs-patch
patch-preview.txt gh, 2013-07-19.10:10:19 text/x-darcs-patch
patch-preview.txt gh, 2013-07-19.10:26:32 text/x-darcs-patch
unnamed gh, 2013-07-18.12:56:57
unnamed gh, 2013-07-18.14:19:59
unnamed gh, 2013-07-19.10:10:19
unnamed gh, 2013-07-19.10:26:32
See mailing list archives for discussion on individual patches.
Messages
msg16910 (view) Author: gh Date: 2013-07-18.12:56:57
Wanted: MAC OSX users that can confirm that this patch works well.

This patch basically makes darcs using ~/.cache/darcs/ instead of
~/.darcs/cache. Unless $XDG_CACHE_HOME is set, in which case it
will use $XDG_CACHE_HOME/darcs/.

If $XDG_CACHE_HOME is set but does not exist, or if it
is not set and ~/.cache does not exist, the missing directory
is created with permissions 0700.

Under for Mac OSX, this patch makes darcs use the directory
~/Library/Caches/, which is the current norm.

The behaviour under Windows is not modified, there does not seem
to be any norm for caches.

See:

* <http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html>
* <http://bugs.darcs.net/issue2181>

2 patches for repository http://darcs.net:

Thu Jul 18 13:26:29 CEST 2013  Guillaume Hoffmann <guillaumh@gmail.com>
  * merge Darcs.Util.IO into Darcs.Util.File

Thu Jul 18 14:50:04 CEST 2013  Guillaume Hoffmann <guillaumh@gmail.com>
  * resolve issue2181: put cache in $XDG_CACHE_HOME (~/.cache by default)
Attachments
msg16911 (view) Author: gh Date: 2013-07-18.14:19:59
This version fixes a warning when ~/.darcs/cache is not present.

2 patches for repository http://darcs.net:

Thu Jul 18 13:26:29 CEST 2013  Guillaume Hoffmann <guillaumh@gmail.com>
  * merge Darcs.Util.IO into Darcs.Util.File

Thu Jul 18 16:03:53 CEST 2013  Guillaume Hoffmann <guillaumh@gmail.com>
  * resolve issue2181: put cache in $XDG_CACHE_HOME (~/.cache by default)
Attachments
msg16912 (view) Author: gh Date: 2013-07-19.10:10:19
This amended version used System.Info( os ) instead of CPP flags,
hence does not touch darcs.cabal.

2 patches for repository http://darcs.net:

Thu Jul 18 13:26:29 CEST 2013  Guillaume Hoffmann <guillaumh@gmail.com>
  * merge Darcs.Util.IO into Darcs.Util.File

Fri Jul 19 11:17:22 CEST 2013  Guillaume Hoffmann <guillaumh@gmail.com>
  * resolve issue2181: put cache in $XDG_CACHE_HOME (~/.cache by default)
Attachments
msg16913 (view) Author: gh Date: 2013-07-19.10:26:32
With a comment about Windows detection.

2 patches for repository http://darcs.net:

Thu Jul 18 13:26:29 CEST 2013  Guillaume Hoffmann <guillaumh@gmail.com>
  * merge Darcs.Util.IO into Darcs.Util.File

Fri Jul 19 12:26:01 CEST 2013  Guillaume Hoffmann <guillaumh@gmail.com>
  * resolve issue2181: put cache in $XDG_CACHE_HOME (~/.cache by default)
Attachments
msg16914 (view) Author: owst Date: 2013-07-19.10:36:34
I've looked over the patch, and the code looks good. I can't test for
OSX though.
msg16916 (view) Author: gh Date: 2013-07-19.13:23:03
Accepted by owst http://irclog.perlgeek.de/darcs/2013-07-19#i_7345510 by
will wait a little to push them to reviewed, to ask for Mac OSX testers.
msg16921 (view) Author: gh Date: 2013-07-20.10:59:31
Eric confirmed on the mailing list that it worked on OSX.
History
Date User Action Args
2013-07-18 12:56:57ghcreate
2013-07-18 14:19:59ghsetfiles: + patch-preview.txt, merge-darcs_util_io-into-darcs_util_file.dpatch, unnamed
messages: + msg16911
2013-07-19 10:10:20ghsetfiles: + patch-preview.txt, merge-darcs_util_io-into-darcs_util_file.dpatch, unnamed
messages: + msg16912
2013-07-19 10:26:32ghsetfiles: + patch-preview.txt, merge-darcs_util_io-into-darcs_util_file.dpatch, unnamed
messages: + msg16913
2013-07-19 10:36:34owstsetmessages: + msg16914
2013-07-19 13:23:03ghsetstatus: needs-screening -> accepted
messages: + msg16916
2013-07-19 13:23:08ghsetstatus: accepted -> needs-review
2013-07-20 10:59:32ghsetstatus: needs-review -> accepted
messages: + msg16921