Patch 1088: refuse empty patch names - Darcs bug tracker

Created on 2013-07-25.14:40:10 by gh, last changed 2013-11-20.20:39:12 by gh.

Files
File name	Status	Uploaded	Type	Edit	Remove
patch-preview.txt		gh, 2013-07-25.14:40:10	text/x-darcs-patch
patch-preview.txt		gh, 2013-10-25.18:28:35	text/x-darcs-patch
patch-preview.txt		gh, 2013-10-27.20:51:45	text/x-darcs-patch
refuse-empty-patch-names.dpatch		gh, 2013-07-25.14:40:10	application/x-darcs-patch
refuse-incorrect-patch-names-_empty-or-starting-with-tag_.dpatch		gh, 2013-10-25.18:28:36	application/x-darcs-patch
refuse-incorrect-patch-names-_empty-or-starting-with-tag_.dpatch		gh, 2013-10-27.20:51:45	application/x-darcs-patch
unnamed		gh, 2013-07-25.14:40:10
unnamed		gh, 2013-10-25.18:28:36
unnamed		gh, 2013-10-27.20:51:45

See mailing list archives for discussion on individual patches.

Messages
msg16948 (view)	Author: gh	Date: 2013-07-25.14:40:10
1 patch for repository http://darcs.net: Thu Jul 25 16:35:40 CEST 2013 Guillaume Hoffmann <guillaumh@gmail.com> * refuse empty patch names Attachments patch-preview.txt refuse-empty-patch-names.dpatch unnamed
msg16949 (view)	Author: gh	Date: 2013-07-25.15:08:04
Please don't screen for now, it needs corrections, and actually invoking the editor in the adequate cases when an empty name is passed with the -m flag is quite invasive. Also letting users having an empty named patch instead of losing their selection could be actually better.
msg17074 (view)	Author: gh	Date: 2013-10-25.18:28:36
1 patch for repository http://darcs.net: Fri Oct 25 15:18:55 ART 2013 Guillaume Hoffmann <guillaumh@gmail.com> * refuse incorrect patch names (empty or starting with TAG) If an incorrect name is given, a warning is displayed and the user is prompted to enter a valid name on standard input. Attachments patch-preview.txt refuse-incorrect-patch-names-_empty-or-starting-with-tag_.dpatch unnamed
msg17075 (view)	Author: gh	Date: 2013-10-25.18:31:44
This last patch also makes darcs fall back on the command line prompt when no working text editor is present (when this happens, the patch name-and-description file remaining empty and darcs believes the user entered an empty patch name). This seem to happen under Windows, in particular, altought I can not test it myself.
msg17077 (view)	Author: gh	Date: 2013-10-27.20:51:45
In this last version, I've enhanced a little the output of `darcs help record`. I'm screening it now. 1 patch for repository http://darcs.net: Sun Oct 27 17:01:27 ART 2013 Guillaume Hoffmann <guillaumh@gmail.com> * refuse incorrect patch names (empty or starting with TAG) If an incorrect name is given, a warning is displayed and the user is prompted to enter a valid name on standard input. Attachments patch-preview.txt refuse-incorrect-patch-names-_empty-or-starting-with-tag_.dpatch unnamed
msg17085 (view)	Author: gh	Date: 2013-11-20.20:39:12
Self-accept.

History
Date	User	Action	Args
2013-07-25 14:40:10	gh	create
2013-07-25 15:08:04	gh	set	status: needs-screening -> followup-requested assignedto: gh messages: + msg16949
2013-10-25 18:28:36	gh	set	files: + patch-preview.txt, refuse-incorrect-patch-names-_empty-or-starting-with-tag_.dpatch, unnamed messages: + msg17074
2013-10-25 18:31:45	gh	set	messages: + msg17075
2013-10-27 20:51:45	gh	set	files: + patch-preview.txt, refuse-incorrect-patch-names-_empty-or-starting-with-tag_.dpatch, unnamed messages: + msg17077
2013-10-27 20:52:09	gh	set	status: followup-requested -> needs-review
2013-11-20 20:39:12	gh	set	status: needs-review -> accepted messages: + msg17085