Patch 1131 Resolve Issue1416: put log files in tempdir instead of...

Title Resolve Issue1416: put log files in tempdir instead of...
Superseder Nosy List alex.aegf
Related Issues
Status obsoleted Assigned To

Created on 2014-04-04.01:25:15 by alex.aegf, last changed 2014-04-08.14:04:30 by gh.

File name Status Uploaded Type Edit Remove
patch-preview.txt alex.aegf, 2014-04-04.01:25:14 text/x-darcs-patch
resolve-issue1416_-put-log-files-in-tempdir-instead-of-in-working-dir_.dpatch alex.aegf, 2014-04-04.01:25:14 application/x-darcs-patch
unnamed alex.aegf, 2014-04-04.01:25:14
See mailing list archives for discussion on individual patches.
msg17261 (view) Author: alex.aegf Date: 2014-04-04.01:25:14
1 patch for repository http://darcs.net:

Thu Apr  3 22:05:04 ART 2014  Ale Gadea <alex.aegf@gmail.com>
  * Resolve Issue1416: put log files in tempdir instead of in working dir.
  The temporal files are found in _darcs.
  For the commands amend-record, record and tag, the temp file is path_description.txt
  and is persistent, ie always have the last message whether failed or not the command.
  For send, we use two files, darcs-send for the editing and darcs-send.final for the 
  backup. If all is ok, the files are removed.
msg17262 (view) Author: gh Date: 2014-04-04.04:58:45
Nice. It seems to work well for record, amend, tag (without or with
--logfile and --delete-logfile).

However with send, when given "--logfile" it does not seem to clean
_darcs/darcs-send.final  . Moreover when passed "--delete-log-file", it
does not delete the given log file.

To enhance the implementation for send (when no logfile is given), you
can delete darcs-send right after copying it to .final (currently you're
doing it not at the very end). In fact you could just rename the file to
.final (and then read its contents with readDocBinFile).

About the patch itself, please send an amended version without unrelated
hunks, lines or characters:

* hunk ./src/Darcs/UI/Commands/Record.hs 20
* hunk ./src/Darcs/UI/Commands/Record.hs 407 (last line with trailing
* hunk ./src/Darcs/UI/Commands/Record.hs 530
* hunk ./src/Darcs/Util/Global.hs 177 (trailing whitespace)

In the patch long description: temporal -> temporary.
Date User Action Args
2014-04-04 01:25:15alex.aegfcreate
2014-04-04 04:58:45ghsetmessages: + msg17262
2014-04-08 14:04:30ghsetstatus: needs-screening -> obsoleted