darcs

Patch 1156 resolve issue2364: don't break list of 'bad sources'

Title resolve issue2364: don't break list of 'bad sources'
Superseder Nosy List trofi
Related Issues
Status accepted Assigned To
Milestone

Created on 2014-05-13.19:22:39 by trofi, last changed 2014-05-13.21:45:29 by ganesh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt trofi, 2014-05-13.19:22:38 text/x-darcs-patch
resolve-issue2364_-don_t-break-list-of-_bad-sources_.dpatch trofi, 2014-05-13.19:22:38 application/x-darcs-patch
unnamed trofi, 2014-05-13.19:22:38
See mailing list archives for discussion on individual patches.
Messages
msg17450 (view) Author: trofi Date: 2014-05-13.19:22:38
1 patch for repository http://darcs.net:

Tue May 13 22:07:19 FET 2014  Sergei Trofimovich <slyfox@community.haskell.org>
  * resolve issue2364: don't break list of 'bad sources'
  
  This time the bug manifested on a simple operation:
  $ darcs record -a -m "something"
  
  Attempt to write a patch resulted in something like:
    Failed to record patch 'hello'
  
    HINT: I could not reach the following repositories:
          http://repetae.net/repos/jhc
          /home/st/.darcs/cache
          /home/st/.cache/darcs
          /home/st/dev/darcs/jhc
        If you're not using them, you should probably delete
  
  The sequence should be the following:
      1. store patch to inventory/foo
      2. try to store to a writable cache (say, ~/.darcs/cache/patches)
      3. fail to write
      4. filter out bad caches
      5. try again
      6. copy from cache to patches/
  
  Due to missing NOINLINE step 4. led to
  all caches treated as writable, thus step 5
  failed without a chance for patch to
  go to 'patches/'.
  
  As a side-effect building darcs with -O0 produced seemingly working darcs.
  Reported-by: Ivan Miljenovic
Attachments
msg17452 (view) Author: ganesh Date: 2014-05-13.21:45:29
This one is obviously a good thing so pushing to screened and reviewed.

I haven't lifted the restriction on GHC 7.8 in darcs.cabal, but it might 
make sense to do that to make it easier for people to test that all is ok 
now.
History
Date User Action Args
2014-05-13 19:22:39troficreate
2014-05-13 21:45:29ganeshsetstatus: needs-screening -> accepted
messages: + msg17452