darcs

Patch 1199 resolve issue1514: send --minimize-conte... (and 1 more)

Title resolve issue1514: send --minimize-conte... (and 1 more)
Superseder Nosy List gh
Related Issues
Status accepted Assigned To
Milestone

Created on 2014-10-15.21:09:38 by gh, last changed 2014-11-03.19:45:42 by gh.

Files
File name Status Uploaded Type Edit Remove
add-__no_minimize-flag-to-fix-broken-tests.dpatch gh, 2014-10-23.14:04:30 application/x-darcs-patch
minimize-bundle-contexts-by-default_-allow-ctrl_c-or-__no_minimize.dpatch gh, 2014-10-17.17:43:24 application/x-darcs-patch
patch-preview.txt gh, 2014-10-15.21:09:38 text/x-darcs-patch
patch-preview.txt ganesh, 2014-10-16.17:45:03 text/x-darcs-patch
patch-preview.txt gh, 2014-10-17.17:43:24 text/x-darcs-patch
patch-preview.txt gh, 2014-10-23.14:04:30 text/x-darcs-patch
pattern_match-against-sealed-rather-than-using-unsafeunseal.dpatch ganesh, 2014-10-16.17:45:04 application/x-darcs-patch
resolve-issue1514_-send-__minimize_context-flag-for-send.dpatch gh, 2014-10-15.21:09:38 application/x-darcs-patch
unnamed gh, 2014-10-15.21:09:38
unnamed ganesh, 2014-10-16.17:45:04
unnamed gh, 2014-10-17.17:43:24
unnamed gh, 2014-10-23.14:04:30
See mailing list archives for discussion on individual patches.
Messages
msg17689 (view) Author: gh Date: 2014-10-15.21:09:38
This piece of code implements --minimize for the commands
send and obliterate -O. The idea of this flag is to generate
patch bundles with minimal contexts. It does so by exhaustively
trying to remove patches from it, so don't expect it to run fast
on big context (I haven't tested it yet apart from small toy cases).

2 patches for repository http://darcs.net:

patch f07cbca50d0f456c667a62866d5ebe08b1b48b15
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Wed Oct 15 18:04:57 ART 2014
  * resolve issue1514: send --minimize-context flag for send

patch a336370473b914ac10471fee97c6c18335b1acbf
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Wed Oct 15 18:05:34 ART 2014
  * --minimize for obliterate -O
Attachments
msg17692 (view) Author: ganesh Date: 2014-10-16.17:45:04
1 patch for repository darcs-unstable@darcs.net:screened:

Thu Oct 16 18:43:17 BST 2014  Ganesh Sittampalam <ganesh@earth.li>
  * pattern-match against Sealed rather than using unsafeUnseal
Attachments
msg17697 (view) Author: gh Date: 2014-10-17.17:43:24
Since context minimizing is surprisingly fast (in the darcs.net repo
at least) let's try enabling it by default.

1 patch for repository http://darcs.net:

patch 1b0ac20e055f01327857c7e96be40fd692a3bdd6
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Fri Oct 17 14:40:32 ART 2014
  * minimize bundle contexts by default, allow ctrl-c or --no-minimize
Attachments
msg17719 (view) Author: ganesh Date: 2014-10-22.12:00:12
The following tests seem to be broken by this - haven't investigated 
the details:

apply-reorder.sh (Darcs2) (PatienceDiff)
convert.sh (Darcs1) (PatienceDiff)
issue1873-apply-failed-to-read-patch.sh (Darcs2) (PatienceDiff)
issue1909-unrecord-O-misses-tag.sh (Darcs2) (PatienceDiff)
output.sh (Darcs2) (PatienceDiff)
send-output-v1.sh (Darcs1) (PatienceDiff)
send-output-v2.sh (Darcs2) (PatienceDiff)
msg17721 (view) Author: gh Date: 2014-10-23.14:04:30
Fixing the tests. I guess it it easier to write tests that
work with non-minimized contexts.

On a related note, knowing that darcs now minimizes the context of
bundles, I added an explicit dependency to "minimize bundle
contexts by default".

1 patch for repository http://darcs.net:

patch c2a9e61eb01ef1c9f47aebd74c0912bc263ca11f
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Thu Oct 23 11:00:32 ART 2014
  * add --no-minimize flag to fix broken tests
Attachments
msg17736 (view) Author: gh Date: 2014-11-03.19:45:42
Self-accept.
History
Date User Action Args
2014-10-15 21:09:38ghcreate
2014-10-15 21:11:28ghsetstatus: needs-screening -> needs-review
2014-10-16 17:45:04ganeshsetfiles: + patch-preview.txt, pattern_match-against-sealed-rather-than-using-unsafeunseal.dpatch, unnamed
messages: + msg17692
2014-10-17 17:43:25ghsetfiles: + patch-preview.txt, minimize-bundle-contexts-by-default_-allow-ctrl_c-or-__no_minimize.dpatch, unnamed
messages: + msg17697
2014-10-22 12:00:12ganeshsetstatus: needs-review -> review-in-progress
messages: + msg17719
2014-10-23 14:04:31ghsetfiles: + patch-preview.txt, add-__no_minimize-flag-to-fix-broken-tests.dpatch, unnamed
messages: + msg17721
2014-11-03 19:45:42ghsetstatus: review-in-progress -> accepted
messages: + msg17736