A few code simplifications and a bugfix.

3 patches for repository darcs-unstable@darcs.net:screened:

Tue Oct 21 15:06:58 BST 2014  Ganesh Sittampalam <ganesh@earth.li>
  * clarify naming of applyPatches functions

Tue Oct 21 17:08:25 BST 2014  Ganesh Sittampalam <ganesh@earth.li>
  * Share applyPatches code between pull and apply
  
  Abstract the applyPatches function from the apply command, and make pull
  use it.
  
  This means the following changes to apply:
  
   - The outcome is now displayed using 'putInfo', which means it will
     respect options like '-q' where it didn't before. This seems reasonable.
  
  It means the following changes to pull:
  
   - We now call 'setEnvDarcsPatches'. This seems reasonable.
  
   - We now call 'withSignalsBlocked' when applying patches. I think this is
     harmless or an improvement.
  
   - The output messages are a bit more generic, but I don't think any important
     detail is lost.
  
   - We now call 'redirectOutput' around the messages. --reply isn't passed
     to pull so this should make no difference.
  

Tue Oct 21 19:24:11 BST 2014  Ganesh Sittampalam <ganesh@earth.li>
  * resolve issue2403: need to avoid moving the rebase patch to the end
  
  This bug is a pretty good example of why the "rebase internal patch" is a rather
  nasty hack - see 'Note [Rebase representation]' in src/Darcs/Patch/Rebase.hs

Attachments

• clarify-naming-of-applypatches-functions.dpatch
• patch-preview.txt
• unnamed

>   * clarify naming of applyPatches functions

A comment/preparation patch, easy to get. OK.

> * Share applyPatches code between pull and apply

Introduces Darcs.UI.ApplyPatches, eliminates some code duplication. I
agree with the long description of the patch. Nice!

> * resolve issue2403: need to avoid moving the rebase patch to the end

Fixes rebase pull --reorder by only reordering patches that are not
"internal" (= everyone except the rebase patch).
Thanks for the comment on tentativelyReplacePatches.
Accepted.