Patch 1208: push the WhichChanges choice into the Pa... (and 1 more) - Darcs bug tracker

Title	push the WhichChanges choice into the Pa... (and 1 more)
Superseder		Nosy List	ganesh
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2014-11-05.18:39:23 by ganesh, last changed 2014-11-15.20:06:14 by gh.

Files
File name	Status	Uploaded	Type	Edit	Remove
patch-preview.txt		ganesh, 2014-11-05.18:39:22	text/x-darcs-patch
push-the-whichchanges-choice-into-the-patchselectioncontext.dpatch		ganesh, 2014-11-05.18:39:22	application/x-darcs-patch
unnamed		ganesh, 2014-11-05.18:39:22

See mailing list archives for discussion on individual patches.

Messages
msg17747 (view)	Author: ganesh	Date: 2014-11-05.18:39:22
A couple of refactorings. 2 patches for repository darcs-unstable@darcs.net:screened: Wed Nov 5 18:02:26 GMT 2014 Ganesh Sittampalam <ganesh@earth.li> * push the WhichChanges choice into the PatchSelectionContext This removes the need to pass it around explicitly so much, and seems like a natural approach. In particular it demonstrats that the value doesn't change during a selection. Wed Nov 5 18:02:46 GMT 2014 Ganesh Sittampalam <ganesh@earth.li> * rename the confusing concept of 'Tag' in Darcs.Patch.Choices to 'Label' They have nothing to do with darcs tags Attachments patch-preview.txt push-the-whichchanges-choice-into-the-patchselectioncontext.dpatch unnamed
msg17806 (view)	Author: gh	Date: 2014-11-15.20:06:09
> * push the WhichChanges choice into the PatchSelectionContext Looks better now, ok. > * rename the confusing concept of 'Tag' in Darcs.Patch.Choices to 'Label' Thanks! I agree that was confusing. I accept this bundle, also into branch-2.10 since the patches for "tag --ask-deps" depend on this.

History
Date	User	Action	Args
2014-11-05 18:39:23	ganesh	create
2014-11-05 19:50:32	gh	set	status: needs-screening -> needs-review
2014-11-15 20:06:10	gh	set	messages: + msg17806
2014-11-15 20:06:14	gh	set	status: needs-review -> accepted