darcs

Patch 1209 Initial implementation of --ask-deps fla... (and 2 more)

Title Initial implementation of --ask-deps fla... (and 2 more)
Superseder Nosy List ganesh
Related Issues
Status accepted Assigned To
Milestone

Created on 2014-11-05.18:40:16 by ganesh, last changed 2014-11-15.20:36:23 by gh.

Files
File name Status Uploaded Type Edit Remove
initial-implementation-of-__ask_deps-flag-to-darcs-tag.dpatch ganesh, 2014-11-05.18:40:15 application/x-darcs-patch
patch-preview.txt ganesh, 2014-11-05.18:40:15 text/x-darcs-patch
unnamed ganesh, 2014-11-05.18:40:15
See mailing list archives for discussion on individual patches.
Messages
msg17748 (view) Author: ganesh Date: 2014-11-05.18:40:15
3 patches for repository darcs-unstable@darcs.net:screened:

Wed Nov  5 18:05:31 GMT 2014  Ganesh Sittampalam <ganesh@earth.li>
  * Initial implementation of --ask-deps flag to darcs tag
  
  A user may want to tag just a subset of their repo, and this is much more
  convenient than making a separate repo just to tag.
  
  Note that this initial implementation is quite inefficient - it grabs
  all the patches in the repo in one big list.

Wed Nov  5 18:09:51 GMT 2014  Ganesh Sittampalam <ganesh@earth.li>
  * Disallow "skip all" option in interactive selection for tag --ask-deps
  
  The default for tags is to depend on all patches. --ask-deps allows some
  to be left out, but the user should explicitly select those. Trying to
  leave out most patches in a large repository is likely to be very slow
  and is probably a mistake.
  
  The implementation, exposing an 'allowSkipAll' constructor field on
  PatchSelectionContext, is a bit ad-hoc. However the alternative would be
  extending the selectionContextXXX functions with another parameter for
  this one special case. I think in general it makes sense to allow this
  style for overriding defaults.
  

Wed Nov  5 18:22:59 GMT 2014  Ganesh Sittampalam <ganesh@earth.li>
  * basic test of tag --ask-deps
Attachments
msg17760 (view) Author: bfrk Date: 2014-11-08.20:35:12
I have often wanted that feature. Very cool!
msg17807 (view) Author: gh Date: 2014-11-15.20:36:23
> * Initial implementation of --ask-deps flag to darcs tag

OK. I'm surprise there was not off the shelf function to build a
PatchSet from an FL (PatchInfo a).

> * Disallow "skip all" option in interactive selection for tag --ask-deps

I already said on darcs-users that I agreed with this. Ok.

> * basic test of tag --ask-deps

Good.

Accepted.
History
Date User Action Args
2014-11-05 18:40:16ganeshcreate
2014-11-05 19:50:21ghsetstatus: needs-screening -> needs-review
2014-11-08 20:35:12bfrksetmessages: + msg17760
2014-11-15 20:36:23ghsetstatus: needs-review -> accepted
messages: + msg17807