darcs

Patch 121 Resolve issue1362: Mention repo name in mail send body

Title Resolve issue1362: Mention repo name in mail send body
Superseder Nosy List darcs-users, nomeata, tux_rocker
Related Issues patch bundle email should mention repository name
View: 1362
Status accepted Assigned To nomeata
Milestone

Created on 2009-12-24.11:37:35 by nomeata, last changed 2011-05-10.20:36:22 by darcswatch. Tracked on DarcsWatch.

Files
File name Status Uploaded Type Edit Remove
resolve-issue1362_-mention-repo-name-in-mail-send-body.dpatch nomeata, 2009-12-24.11:37:34 text/x-darcs-patch
resolve-issue1362_-mention-repo-name-in-mail-send-body.dpatch nomeata, 2009-12-26.20:29:19 text/x-darcs-patch
unnamed nomeata, 2009-12-24.11:37:34 text/plain
unnamed nomeata, 2009-12-26.20:29:19 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg9677 (view) Author: nomeata Date: 2009-12-24.11:37:34
1 patch for repository http://darcs.net:

Thu Dec 24 12:34:44 CET 2009  Joachim Breitner <mail@joachim-breitner.de>
  * Resolve issue1362: Mention repo name in mail send body

(This mail submission is also the proof that the patch works, and how it looks :-))
Attachments
msg9686 (view) Author: tux_rocker Date: 2009-12-26.16:50:30
In this form, the patch breaks the build. I get the error:

  src/Darcs/Commands/Send.lhs:445:68: Not in scope: `<>'


And line 445 of Send.lhs looks like:

                      <+> text "for repository" <+> text their_name <> text ":"

Could you please amend it (I suppose the <> should be a <+>)?

Regards,
Reinier
msg9688 (view) Author: nomeata Date: 2009-12-26.20:04:28
Hi,

Am Samstag, den 26.12.2009, 16:50 +0000 schrieb Reinier Lamers:
> Reinier Lamers <tux_rocker@reinier.de> added the comment:
> 
> In this form, the patch breaks the build. I get the error:
> 
>   src/Darcs/Commands/Send.lhs:445:68: Not in scope: `<>'
> 
> 
> And line 445 of Send.lhs looks like:
> 
>                       <+> text "for repository" <+> text their_name <> text ":"
> 
> Could you please amend it (I suppose the <> should be a <+>)?

darn, I guess I recorded before saving that fix, or something. Will
amend later today.

Greetings,
Joachim

-- 
Joachim "nomeata" Breitner
  mail: mail@joachim-breitner.de | ICQ# 74513189 | GPG-Key: 4743206C
  JID: nomeata@joachim-breitner.de | http://www.joachim-breitner.de/
  Debian Developer: nomeata@debian.org
msg9689 (view) Author: nomeata Date: 2009-12-26.20:29:19
Hi,

indeed, I recorded before saving the last change, or maybe I tried to amend and
pressed the wrong button or so. Anyways, this should work now and sorry for the
extra round-trip.

Greetings,
Joachim

2 patches for repository http://darcs.net:

Thu Dec 24 12:34:44 CET 2009  Joachim Breitner <mail@joachim-breitner.de>
  * Resolve issue1362: Mention repo name in mail send body

Sat Dec 26 21:24:45 CET 2009  Joachim Breitner <mail@joachim-breitner.de>
  * Also import (<>)
Attachments
msg9692 (view) Author: darcswatch Date: 2009-12-27.14:25:34
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-818af1d6c26ef3a015c6534338c1385343589273
msg14244 (view) Author: darcswatch Date: 2011-05-10.20:06:11
This patch bundle (with 2 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-420876d546711b86e18c257bf1ac42543ab425c2
msg14286 (view) Author: darcswatch Date: 2011-05-10.20:36:22
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-818af1d6c26ef3a015c6534338c1385343589273
History
Date User Action Args
2009-12-24 11:37:35nomeatacreate
2009-12-24 11:38:07darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-818af1d6c26ef3a015c6534338c1385343589273
2009-12-24 11:41:04nomeatasetissues: + patch bundle email should mention repository name
2009-12-26 16:38:19tux_rockersetstatus: needs-review -> review-in-progress
assignedto: tux_rocker
nosy: + tux_rocker
2009-12-26 16:50:27tux_rockersetstatus: review-in-progress -> followup-requested
assignedto: tux_rocker -> nomeata
2009-12-26 16:50:31tux_rockersetmessages: + msg9686
2009-12-26 20:04:30nomeatasetmessages: + msg9688
2009-12-26 20:29:20nomeatasetfiles: + resolve-issue1362_-mention-repo-name-in-mail-send-body.dpatch, unnamed
messages: + msg9689
2009-12-26 20:31:08darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-818af1d6c26ef3a015c6534338c1385343589273 -> http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-420876d546711b86e18c257bf1ac42543ab425c2
2009-12-27 14:25:35darcswatchsetstatus: followup-requested -> accepted
messages: + msg9692
2011-05-10 20:06:11darcswatchsetmessages: + msg14244
2011-05-10 20:36:22darcswatchsetmessages: + msg14286