Patch 1212: directly pass around SHA1 of patches instead of string... - Darcs bug tracker

Title	directly pass around SHA1 of patches instead of string...
Superseder		Nosy List	gh
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2014-11-07.11:24:48 by gh, last changed 2014-11-15.20:54:27 by gh.

Files
File name	Status	Uploaded	Type	Edit	Remove
directly-pass-around-sha1-of-patches-instead-of-string-representation.dpatch		gh, 2014-11-07.11:24:47	application/x-darcs-patch
patch-preview.txt		gh, 2014-11-07.11:24:47	text/x-darcs-patch
unnamed		gh, 2014-11-07.11:24:47

See mailing list archives for discussion on individual patches.

Messages
msg17756 (view)	Author: gh	Date: 2014-11-07.11:24:47
Since the patch-index writes and reads patch hashes many times, it is more economical to use the hash itself instead of its string representation. This brings an improvement in memory usage and also of disk usage of the patch index. Memory use of "darcs optimize enable-patch-index" on darcs.net repo: Before: https://www.dropbox.com/sh/v0m2xj7ky3vgkjk/AADW_5ZwJqMqit7sIJJTopQya/sha1/before.pdf?dl=0 After (the datatype SHA1 appears as ABCDE in the report since I did it with an old version of this patch): https://www.dropbox.com/sh/v0m2xj7ky3vgkjk/AAAlla_tMMdyLC3Yo7-uvOEqa/sha1/after.pdf?dl=0 1 patch for repository http://darcs.net: patch bddd039e0b72dace6242272b690a5c97d8fbc0a1 Author: Guillaume Hoffmann <guillaumh@gmail.com> Date: Fri Nov 7 08:08:25 ART 2014 * directly pass around SHA1 of patches instead of string representation Attachments directly-pass-around-sha1-of-patches-instead-of-string-representation.dpatch patch-preview.txt unnamed
msg17809 (view)	Author: gh	Date: 2014-11-15.20:54:27
Self accept, goes in 2.10 as optimization.

History
Date	User	Action	Args
2014-11-07 11:24:48	gh	create
2014-11-07 11:25:57	gh	set	status: needs-screening -> needs-review
2014-11-15 20:54:27	gh	set	status: needs-review -> accepted messages: + msg17809