darcs

Patch 1213 fix the convert command (convert.sh test failed)

Title fix the convert command (convert.sh test failed)
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To
Milestone

Created on 2014-11-08.23:25:51 by bfrk, last changed 2015-02-12.14:05:59 by gh.

Files
File name Status Uploaded Type Edit Remove
fix-the-convert-command-_convert_sh-test-failed_.dpatch bfrk, 2014-11-08.23:25:50 application/x-darcs-patch
patch-preview.txt bfrk, 2014-11-08.23:25:50 text/x-darcs-patch
unnamed bfrk, 2014-11-08.23:25:50
See mailing list archives for discussion on individual patches.
Messages
msg17761 (view) Author: bfrk Date: 2014-11-08.23:25:50
See my reply to Ganesh's comments about the new options system integration.

1 patch for repository http://darcs.net/screened:

patch c2551f3d59aa94efb688088de702f60c0455864e
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Sun Nov  9 00:24:06 CET 2014
  * fix the convert command (convert.sh test failed)
  
  This patch demonstrates how to get rid of explicit flag testing in command
  implementations as well as how to handle the cases where flags are add to
  the flag list. Here, we remove flag testing and insertions for the
  UseFormat1 and UseFormat2 flags.
Attachments
msg17778 (view) Author: ganesh Date: 2014-11-13.06:50:57
I've pushed this to screened.

Ben - you can generally just push your own patches to screened or 
set them in-discussion or similar if they're not ready yet. The idea 
of 'screened' is that patches should get into it quickly to avoid 
future conflicts, and then we take a bit longer and have someone 
else look at them before they get to 'reviewed'.
msg17906 (view) Author: gh Date: 2014-12-15.18:00:14
Looks like this one was already pushed to reviewed; but the change looks
good (updating patch format detection using the correct piece of code
since the introduction of Ben's new flag system).
msg18087 (view) Author: gh Date: 2015-02-12.14:05:59
Pulling it into branch 2.10.
History
Date User Action Args
2014-11-08 23:25:51bfrkcreate
2014-11-13 06:50:57ganeshsetstatus: needs-screening -> needs-review
messages: + msg17778
2014-12-15 18:00:15ghsetstatus: needs-review -> accepted
messages: + msg17906
2015-02-12 14:05:59ghsetmessages: + msg18087