darcs

Patch 1215 use bytestring functions dropWhile and break instead o...

Title use bytestring functions dropWhile and break instead o...
Superseder Nosy List gh
Related Issues
Status accepted Assigned To
Milestone

Created on 2014-11-12.18:55:34 by gh, last changed 2014-11-20.18:45:05 by gh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt gh, 2014-11-12.18:55:33 text/x-darcs-patch
unnamed gh, 2014-11-12.18:55:33
use-bytestring-functions-dropwhile-and-break-instead-of-ours.dpatch gh, 2014-11-12.18:55:33 application/x-darcs-patch
See mailing list archives for discussion on individual patches.
Messages
msg17772 (view) Author: gh Date: 2014-11-12.18:55:33
The implementation of these functions in darcs is from 2008.
With this patch we trim some lines of code and have a small memory
improvement, here on patch index creation in the darcs.net repo:

before:
        total time  =        5.95 secs   (5945 ticks @ 1000 us, 1 processor)
        total alloc = 4,126,233,968 bytes  (excludes profiling overheads)

after (two measurings):
        total time  =        5.85 secs   (5853 ticks @ 1000 us, 1 processor)
        total alloc = 3,892,040,296 bytes  (excludes profiling overheads)

        total time  =        5.97 secs   (5969 ticks @ 1000 us, 1 processor)
        total alloc = 3,892,020,360 bytes  (excludes profiling overheads)

1 patch for repository http://darcs.net:

patch 0e0682af43f03b9e3299ecee959596b7e80d0c3b
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Wed Nov 12 15:45:34 ART 2014
  * use bytestring functions dropWhile and break instead of ours
Attachments
msg17850 (view) Author: gh Date: 2014-11-20.18:45:04
Self-accept, goes in 2.10 as optimization.
History
Date User Action Args
2014-11-12 18:55:34ghcreate
2014-11-12 19:04:37ghsetstatus: needs-screening -> needs-review
2014-11-20 18:45:05ghsetstatus: needs-review -> accepted
messages: + msg17850